Properly Handle Nested Dispatches #19

Merged
kske merged 3 commits from b/nested-dispatch into develop 2 weeks ago
kske commented 3 weeks ago
Owner

Instead of setting a boolean when a dispatch happens, an integer is incremented when the dispatch begins and decremented when it ends, thus keepnig track of nested calls to the dispatch method.

In addition, a minor bug has been fixed that caused errors (for example thrown by a JUnit assertion) to be handled using an exception event instead of being transparently propagated to the caller as intended.

Fixes #18

Instead of setting a boolean when a dispatch happens, an integer is incremented when the dispatch begins and decremented when it ends, thus keepnig track of nested calls to the `dispatch` method. In addition, a minor bug has been fixed that caused errors (for example thrown by a JUnit assertion) to be handled using an exception event instead of being transparently propagated to the caller as intended. Fixes #18
kske added the
core
bug
labels 3 weeks ago
kske self-assigned this 3 weeks ago
kske added 3 commits 3 weeks ago
6eebd3c121
Pass errors caused during system event dispatch to caller
74447dea59
Add nested dispatch test
kske requested review from delvh 3 weeks ago
delvh approved these changes 2 weeks ago
kske merged commit b915a5c490 into develop 2 weeks ago
kske deleted branch b/nested-dispatch 2 weeks ago

Reviewers

delvh approved these changes 2 weeks ago
The pull request has been merged as b915a5c490.
Sign in to join this conversation.
Loading…
There is no content yet.