From 2cb124505db50b9e02ddcd4dff0b75ed0470cb1c Mon Sep 17 00:00:00 2001 From: delvh Date: Sun, 16 Aug 2020 23:57:04 +0200 Subject: [PATCH 1/6] Apply suggestions from code review Additionally moved issue sanitization from server to client. Co-authored-by: DieGurke Co-authored-by: CyB3RC0nN0R --- client/.settings/org.eclipse.jdt.ui.prefs | 2 +- client/src/main/java/envoy/client/Main.java | 4 +- .../client/ui/controller/SettingsScene.java | 6 +-- .../client/ui/settings/BugReportPane.java | 8 ++-- .../ui/settings/OnlyIfOnlineSettingsPane.java | 10 ++--- .../java/envoy/client/util/IssueUtil.java | 40 +++++++++++++++++++ common/.settings/org.eclipse.jdt.ui.prefs | 2 +- .../main/java/envoy/event/IssueProposal.java | 26 ++++-------- server/.settings/org.eclipse.jdt.ui.prefs | 2 +- .../processors/IssueProposalProcessor.java | 19 +++------ 10 files changed, 69 insertions(+), 50 deletions(-) create mode 100644 client/src/main/java/envoy/client/util/IssueUtil.java diff --git a/client/.settings/org.eclipse.jdt.ui.prefs b/client/.settings/org.eclipse.jdt.ui.prefs index 359aaeb..8eb1c29 100644 --- a/client/.settings/org.eclipse.jdt.ui.prefs +++ b/client/.settings/org.eclipse.jdt.ui.prefs @@ -6,4 +6,4 @@ org.eclipse.jdt.ui.importorder=java;javax;javafx;org;com;envoy; org.eclipse.jdt.ui.javadoc=true org.eclipse.jdt.ui.ondemandthreshold=4 org.eclipse.jdt.ui.staticondemandthreshold=2 -org.eclipse.jdt.ui.text.custom_code_templates=