Display Current User Status and Unread Message Amount in Status Tray Icon #103

Merged
kske merged 8 commits from f/enhanced-status-tray-icon into develop 2 years ago
kske commented 2 years ago
Owner

Fixes #12

Fixes #12
kske added this to the v0.3-beta milestone 2 years ago
kske added the
M
label 2 years ago
kske self-assigned this 2 years ago
kske requested review from delvh 2 years ago
kske requested review from DieGurke 2 years ago
Poster
Owner

@DieGurke please verify that this works properly on Microsoft Windows.

@DieGurke please verify that this works properly on Microsoft Windows.
delvh approved these changes 2 years ago
delvh left a comment
Owner

👍

👍
DieGurke requested changes 2 years ago
DieGurke left a comment
Owner

First I don't really like the fact that the status tray icon is only displayed if hide on close is enabled. It should rather be enabled at all times.

  • Status display works fine although I don't like the visual appeal as you have to know what is is displaying. (But is ok for now)
  • Whats not ok is the unread messages displaying! First the little square where it is displayed at the moment is way to small as it just cuts of half of the number on Linux Arch and doesn't even display anything on Microsoft Windows.
    I suggest displaying the unread messages amount when the status tray icon is clicked just like the operations you can perform.
First I don't really like the fact that the status tray icon is only displayed if hide on close is enabled. It should rather be enabled at all times. * Status display works fine although I don't like the visual appeal as you have to know what is is displaying. (But is ok for now) * Whats not ok is the unread messages displaying! First the little square where it is displayed at the moment is way to small as it just cuts of half of the number on Linux Arch and doesn't even display anything on Microsoft Windows. I suggest displaying the unread messages amount when the status tray icon is clicked just like the operations you can perform.
Owner

Additionally I noticed a severe bug: if you have unread messages and close the clien't down, the next time you open it again you have the double amount of unread messeges displayed as the client received them twice each. (The number in the status tray icon is more or less comlpetely random after the second start it seems). Please investigate on this!
See #104

Additionally I noticed a severe bug: if you have unread messages and close the clien't down, the next time you open it again you have the double amount of unread messeges displayed as the client received them twice each. (The number in the status tray icon is more or less comlpetely random after the second start it seems). Please investigate on this! See #104
Poster
Owner

@DieGurke the issue on Arch Linux arises from the fact that KDE's status tray API has evolved from what AWT's StatusTray has been designed for (Java 5).

The StatusTrayIcon runs using a legacy API which doesn't seem to handle scaling the same way Eclipse or the rest of Envoy does.

Apart from writing platform-specific C code using JNI / JNA, we cannot do much about this, however @delvh pointed out to me that DPI scaling can actually work without the explicit setting of environment variables.

I will look into the issue you describe for Microsoft Windows, however.

@DieGurke the issue on Arch Linux arises from the fact that KDE's status tray API has evolved from what AWT's `StatusTray` has been designed for (Java 5). The `StatusTrayIcon` runs using a [legacy API ](https://invent.kde.org/plasma/plasma-workspace/-/blob/master/xembed-sni-proxy/Readme.md) which doesn't seem to handle scaling the same way Eclipse or the rest of Envoy does. Apart from writing platform-specific C code using JNI / JNA, we cannot do much about this, however @delvh pointed out to me that DPI scaling can actually work without the explicit setting of environment variables. I will look into the issue you describe for Microsoft Windows, however.
Owner

@DieGurke @kske I guess I know where this bug is originating from: IIRC, loadUserData gets called twice when using token authentication. Each time, the chats get reloaded. And as the totalUnreadAmount always gets updated when readObject gets called, it'll show twice the amount of messages. That is my semi-educated guess.

@DieGurke @kske I guess I know where this bug is originating from: IIRC, `loadUserData` gets called twice when using token authentication. Each time, the chats get reloaded. And as the `totalUnreadAmount` always gets updated when `readObject` gets called, it'll show twice the amount of messages. That is my semi-educated guess.
Owner

First I don’t really like the fact that the status tray icon is only displayed if hide on close is enabled. It should rather be enabled at all times.

@DieGurke as long as the default value stays false, I have nothing against it.

> First I don’t really like the fact that the status tray icon is only displayed if hide on close is enabled. It should rather be enabled at all times. @DieGurke as long as the default value stays `false`, I have nothing against it.
kske requested review from DieGurke 2 years ago
DieGurke approved these changes 2 years ago
DieGurke left a comment
Owner

Basst

Basst
Owner

Sry Baschdt

Sry Baschdt
kske merged commit 889e9b186f into develop 2 years ago
kske deleted branch f/enhanced-status-tray-icon 2 years ago
This repo is archived. You cannot comment on pull requests.
Loading…
There is no content yet.