Refactoring #55

Merged
kske merged 7 commits from refactoring into develop 2 years ago
kske commented 2 years ago
Owner

Refactored large parts of the client:

  • Removed SendEvent in favor of direct access to Client
  • Removed most received object processors in favor of event handlers
  • Moved business logic from ChatScene to LocalDB
  • Make data structures in Chat and LocalDB observable to simplify UI refreshes
  • Remove Javadoc file headers

Closes #21

Refactored large parts of the client: * Removed `SendEvent` in favor of direct access to `Client` * Removed most received object processors in favor of event handlers * Moved business logic from `ChatScene` to `LocalDB` * Make data structures in `Chat` and `LocalDB` observable to simplify UI refreshes * Remove Javadoc file headers Closes #21
kske added this to the v0.2-beta milestone 2 years ago
kske added the
L
client
labels 2 years ago
kske self-assigned this 2 years ago
kske requested review from delvh 2 years ago
kske requested review from DieGurke 2 years ago
kske added a new dependency 2 years ago
delvh approved these changes 2 years ago
delvh left a comment
Owner

👍

👍
// message
if (currentChat != null) localDB.getMessage(evt.getID())
.filter(msg -> msg.getSenderID() == client.getSender().getID())
.ifPresent(msg -> Platform.runLater(messageList::refresh));
delvh commented 2 years ago
Owner

Did you test this? Is the normal refresh enough?

Did you test this? Is the normal refresh enough?
kske commented 2 years ago
Poster
Owner

Yes, it is, as the refresh method refreshed all objects inside the list that might have changed.

Yes, it is, as the `refresh` method refreshed all objects inside the list that might have changed.
kske marked this conversation as resolved
import java.util.regex.Pattern;
/**
* Implements contact name validation.
delvh commented 2 years ago
Owner

Why has that been taken out?

Why has that been taken out?
kske marked this conversation as resolved
/**
* Sends an object to all contact in a set that are online.
delvh commented 2 years ago
Owner

contacts

contact***s***
kske marked this conversation as resolved
/**
* Sends an object to all contact in a set that are online.
delvh commented 2 years ago
Owner

contacts

contact***s***
kske marked this conversation as resolved
delvh added a new dependency 2 years ago
kske merged commit d1d52468bc into develop 2 years ago
kske deleted branch refactoring 2 years ago
delvh removed a dependency 2 years ago
This repo is archived. You cannot comment on pull requests.
Loading…
There is no content yet.