Refactoring #55

kske · 2020-09-26T16:49:48+02:00

kske commented

2020-09-26 16:49:48 +02:00

Refactored large parts of the client:

Removed SendEvent in favor of direct access to Client
Removed most received object processors in favor of event handlers
Moved business logic from ChatScene to LocalDB
Make data structures in Chat and LocalDB observable to simplify UI refreshes
Remove Javadoc file headers

Closes #21

Refactored large parts of the client: * Removed `SendEvent` in favor of direct access to `Client` * Removed most received object processors in favor of event handlers * Moved business logic from `ChatScene` to `LocalDB` * Make data structures in `Chat` and `LocalDB` observable to simplify UI refreshes * Remove Javadoc file headers Closes #21

kske added this to the v0.2-beta milestone 2020-09-26 16:49:48 +02:00

kske added the

L

client

labels 2020-09-26 16:49:48 +02:00

kske self-assigned this 2020-09-26 16:49:48 +02:00

kske requested review from delvh 2020-09-26 17:54:28 +02:00

kske requested review from mpk 2020-09-26 17:54:29 +02:00

kske added a new dependency 2020-09-26 18:13:13 +02:00

#53 Breaking IssueProposals

delvh approved these changes 2020-09-26 22:14:43 +02:00

delvh left a comment

👍

client/src/main/java/envoy/client/ui/controller/ChatScene.java

						
				@ -269,0 +250,4 @@

						// message

						if (currentChat != null) localDB.getMessage(evt.getID())

							.filter(msg -> msg.getSenderID() == client.getSender().getID())

							.ifPresent(msg -> Platform.runLater(messageList::refresh));

delvh commented

2020-09-26 21:50:42 +02:00

Did you test this? Is the normal refresh enough?

kske commented

2020-09-27 12:02:16 +02:00

Yes, it is, as the refresh method refreshed all objects inside the list that might have changed.

Yes, it is, as the `refresh` method refreshed all objects inside the list that might have changed.

kske marked this conversation as resolved

common/src/main/java/envoy/util/Bounds.java

						
				@ -3,12 +3,6 @@ package envoy.util;

				import java.util.regex.Pattern;

				/**

				 * Implements contact name validation.

delvh commented

2020-09-26 22:05:23 +02:00

Why has that been taken out?

kske marked this conversation as resolved

server/src/main/java/envoy/server/net/ObjectWriteProxy.java Outdated

						
				@ -68,7 +62,7 @@ public final class ObjectWriteProxy {

					/**

					 * Sends an object to all contact in a set that are online.

delvh commented

2020-09-26 22:08:43 +02:00

contacts

contact***s***

kske marked this conversation as resolved

server/src/main/java/envoy/server/net/ObjectWriteProxy.java Outdated

						
				@ -77,7 +71,7 @@ public final class ObjectWriteProxy {

					/**

					 * Sends an object to all contact in a set that are online.

delvh commented

2020-09-26 22:08:57 +02:00

contacts

contact***s***

kske marked this conversation as resolved

delvh added a new dependency 2020-09-26 23:13:53 +02:00

#58 Sanitized Issue Proposals

kske referenced this issue from a commit

2020-09-27 12:06:38 +02:00

Merge pull request 'Refactoring' (#55) from refactoring into develop Reviewed-on: https://git.kske.dev/zdm/envoy/pulls/55 Reviewed-by: delvh <leon@kske.dev>

kske merged commit d1d52468bc into develop

2020-09-27 12:06:38 +02:00

kske deleted branch refactoring

2020-09-27 12:06:44 +02:00

delvh removed a dependency 2020-09-27 13:46:19 +02:00

#58 Sanitized Issue Proposals

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks

#53 Breaking IssueProposals

zdm/envoy

Reference: zdm/envoy#55