zdm/envoy
zdm
/
envoy
Archived
3
Fork 0
Code Issues 22 Pull Requests Releases 1 Wiki Activity

Make PersistenceManager Less Error Prone #83

Merged
delvh merged 2 commits from b/crashing-server-with-invalid-objects into develop 2020-10-07 22:13:43 +02:00
Conversation 1 Commits 2 Files Changed 1 +22 -41
delvh commented 2020-10-06 12:15:43 +02:00
Owner
Copy Link

Reduced the amount of code used as a bproduct.

Reduced the amount of code used as a bproduct.
delvh added this to the v0.3-beta milestone 2020-10-06 12:15:43 +02:00
delvh added the
bug
S
server
 labels 2020-10-06 12:15:43 +02:00
delvh self-assigned this 2020-10-06 12:15:43 +02:00
delvh commented 2020-10-06 12:27:05 +02:00
Author
Owner
Copy Link

I really like it when we have real @kske commits...
Adding functionality by removing code is always fun 😆

I really like it when we have real @kske commits... Adding functionality by removing code is always fun 😆
delvh requested review from mpk 2020-10-06 12:33:15 +02:00
delvh requested review from kske 2020-10-06 12:33:18 +02:00
kske approved these changes 2020-10-06 12:58:41 +02:00
kske left a comment
Owner

Yes indeed, this is very elegant 👍

Yes indeed, this is very elegant 👍
delvh changed title from Made PersistenceManager Less Error Prone to Make PersistenceManager Less Error Prone 2020-10-06 16:49:37 +02:00
mpk approved these changes 2020-10-07 21:20:53 +02:00
mpk left a comment
Owner

This looks very well thought out and elegant. Props to you!

This looks very well thought out and elegant. Props to you!
delvh merged commit f2eb89d469 into develop 2020-10-07 22:13:42 +02:00
delvh deleted branch b/crashing-server-with-invalid-objects 2020-10-07 22:13:56 +02:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
kske
mpk
Labels
Clear labels   
client

Envoy Client

  
server

Envoy Server

  
user made

This issue has been created through Envoy

  
bug

Something is not working

  
bugfix

Fixes a bug

  
discussion

This has to be discussed

  
documentation

Related to documentation

  
feature

Introduces a new feature

  
L

Branches where 300 < X <= 600 lines are added and more than one work day is needed

  
M

Branches where 100 < X <=300 lines are added

  
maintenance

Related to project maintenance

  
postponed

Won't be done in the immediate future

  
refactoring

Refactoring code or architectures

  
S

Branches where X <= 100 lines are added or less than 30 minutes are needed

  
wontfix

Will not be fixed in this state of development

  
XL

Branch where X > 600 lines are added and more than two work days are needed

No Label
client
server
user made
bug
bugfix
discussion
documentation
feature
L
M
maintenance
postponed
refactoring
S
wontfix
XL
Milestone
Clear milestone
No items
No Milestone
v0.3-beta
Assignees
Clear assignees
No Assignees
delvh
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: zdm/envoy#83
No description provided.
Delete Branch "b/crashing-server-with-invalid-objects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?