From f97d61e58d057f43f1729217fbc888f4ec4b5268 Mon Sep 17 00:00:00 2001
From: delvh <leon@kske.dev>
Date: Sat, 10 Oct 2020 22:25:39 +0200
Subject: [PATCH 1/6] Add server side contact deletion

---
 .../envoy/client/ui/controller/ChatScene.java |  2 +-
 client/src/main/resources/fxml/ChatScene.fxml |  2 +-
 .../ContactDeletionSinceLastLogin.java        | 15 +++++
 .../java/envoy/util/SerializationUtils.java   |  8 +--
 .../main/java/envoy/server/data/Message.java  |  2 +-
 .../envoy/server/data/PersistenceManager.java | 38 ++++++++++++-
 .../src/main/java/envoy/server/data/User.java | 15 +++++
 .../processors/ContactOperationProcessor.java | 55 +++++++++++++++----
 .../processors/LoginCredentialProcessor.java  |  5 ++
 9 files changed, 122 insertions(+), 20 deletions(-)
 create mode 100644 common/src/main/java/envoy/event/contact/ContactDeletionSinceLastLogin.java

diff --git a/client/src/main/java/envoy/client/ui/controller/ChatScene.java b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
index c2b0ef1..4103a5b 100644
--- a/client/src/main/java/envoy/client/ui/controller/ChatScene.java
+++ b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
@@ -191,7 +191,6 @@ public final class ChatScene implements EventListener, Restorable {
 
 		// Set the design of the box in the upper-left corner
 		settingsButton.setAlignment(Pos.BOTTOM_RIGHT);
-		HBox.setHgrow(spaceBetweenUserAndSettingsButton, Priority.ALWAYS);
 		generateOwnStatusControl();
 
 		Platform.runLater(() -> {
@@ -727,6 +726,7 @@ public final class ChatScene implements EventListener, Restorable {
 			// Else prepend it to the HBox children
 			final var ownUserControl = new ContactControl(localDB.getUser());
 			ownUserControl.setAlignment(Pos.CENTER_LEFT);
+			HBox.setHgrow(ownUserControl, Priority.NEVER);
 			ownContactControl.getChildren().add(0, ownUserControl);
 		}
 	}
diff --git a/client/src/main/resources/fxml/ChatScene.fxml b/client/src/main/resources/fxml/ChatScene.fxml
index d3fb6e9..8221f19 100644
--- a/client/src/main/resources/fxml/ChatScene.fxml
+++ b/client/src/main/resources/fxml/ChatScene.fxml
@@ -167,7 +167,7 @@
 				<HBox id="transparent-background" fx:id="ownContactControl">
 					<children>
 						<Region id="transparent-background" prefWidth="120"
-							fx:id="spaceBetweenUserAndSettingsButton" />
+							fx:id="spaceBetweenUserAndSettingsButton" HBox.hgrow="ALWAYS" />
 						<Button fx:id="settingsButton" mnemonicParsing="false"
 							onAction="#settingsButtonClicked" prefHeight="30.0"
 							prefWidth="30.0" text="" alignment="CENTER">
diff --git a/common/src/main/java/envoy/event/contact/ContactDeletionSinceLastLogin.java b/common/src/main/java/envoy/event/contact/ContactDeletionSinceLastLogin.java
new file mode 100644
index 0000000..cda2483
--- /dev/null
+++ b/common/src/main/java/envoy/event/contact/ContactDeletionSinceLastLogin.java
@@ -0,0 +1,15 @@
+package envoy.event.contact;
+
+import envoy.event.Event.Valueless;
+
+/**
+ * Conveys that either a direct contact or a group member has been deleted while
+ * the user has been offline.
+ *
+ * @author Leon Hofmeister
+ * @since Envoy Common v0.3-beta
+ */
+public class ContactDeletionSinceLastLogin extends Valueless {
+
+	private static final long serialVersionUID = 1L;
+}
diff --git a/common/src/main/java/envoy/util/SerializationUtils.java b/common/src/main/java/envoy/util/SerializationUtils.java
index f556657..4bc4516 100644
--- a/common/src/main/java/envoy/util/SerializationUtils.java
+++ b/common/src/main/java/envoy/util/SerializationUtils.java
@@ -105,7 +105,7 @@ public final class SerializationUtils {
 			file.createNewFile();
 		}
 		try (ObjectOutputStream out = new ObjectOutputStream(new FileOutputStream(file))) {
-			for (var obj : objs)
+			for (final var obj : objs)
 				out.writeObject(obj);
 		}
 	}
@@ -119,7 +119,7 @@ public final class SerializationUtils {
 	 * @since Envoy Common v0.2-alpha
 	 */
 	public static byte[] writeToByteArray(Object obj) throws IOException {
-		ByteArrayOutputStream baos = new ByteArrayOutputStream();
+		final var baos = new ByteArrayOutputStream();
 		try (ObjectOutputStream oout = new ObjectOutputStream(baos)) {
 			oout.writeObject(obj);
 		}
@@ -137,10 +137,10 @@ public final class SerializationUtils {
 	 */
 	public static void writeBytesWithLength(Object obj, OutputStream out) throws IOException {
 		// Serialize object to byte array
-		byte[] objBytes = writeToByteArray(obj);
+		final var objBytes = writeToByteArray(obj);
 
 		// Get length of byte array in bytes
-		byte[] objLen = intToBytes(objBytes.length);
+		final var objLen = intToBytes(objBytes.length);
 
 		// Write length and byte array
 		out.write(objLen);
diff --git a/server/src/main/java/envoy/server/data/Message.java b/server/src/main/java/envoy/server/data/Message.java
index bd5f006..b4c5fe1 100755
--- a/server/src/main/java/envoy/server/data/Message.java
+++ b/server/src/main/java/envoy/server/data/Message.java
@@ -55,7 +55,7 @@ public class Message {
 	@JoinColumn
 	protected User sender;
 
-	@ManyToOne
+	@ManyToOne(cascade = CascadeType.REMOVE)
 	@JoinColumn
 	protected Contact recipient;
 
diff --git a/server/src/main/java/envoy/server/data/PersistenceManager.java b/server/src/main/java/envoy/server/data/PersistenceManager.java
index 230dae8..9350569 100755
--- a/server/src/main/java/envoy/server/data/PersistenceManager.java
+++ b/server/src/main/java/envoy/server/data/PersistenceManager.java
@@ -97,7 +97,20 @@ public final class PersistenceManager {
 	 * @param contact the {@link Contact} to delete
 	 * @since Envoy Server Standalone v0.1-alpha
 	 */
-	public void deleteContact(Contact contact) { remove(contact); }
+	public void deleteContact(Contact contact) {
+		transaction(() -> {
+
+			// Remove this contact from the contact list of his contacts
+			for (final var remainingContact : contact.getContacts())
+				remainingContact.getContacts().remove(contact);
+
+			// Delete messages sent or received by this contact
+			entityManager.createQuery("DELETE FROM Message m WHERE (m.sender = :contact OR m.recipient = :contact )")
+				.setParameter("contact", contact)
+				.executeUpdate();
+		});
+		remove(contact);
+	}
 
 	/**
 	 * Deletes a {@link Message} in the database.
@@ -232,7 +245,7 @@ public final class PersistenceManager {
 		final var	c1	= getContactByID(contactID1);
 		final var	c2	= getContactByID(contactID2);
 
-		// Add users to each others contact lists
+		// Add users to each others contact list
 		c1.getContacts().add(c2);
 		c2.getContacts().add(c1);
 
@@ -240,6 +253,27 @@ public final class PersistenceManager {
 		transaction(() -> { entityManager.merge(c1); entityManager.merge(c2); });
 	}
 
+	/**
+	 * Removes a contact from the contact list of another contact and vice versa.
+	 *
+	 * @param contactID1 the ID of the first contact
+	 * @param contactID2 the ID of the second contact
+	 * @since Envoy Server v0.3-beta
+	 */
+	public void removeContactBidirectional(long contactID1, long contactID2) {
+
+		// Get users by ID
+		final var	c1	= getContactByID(contactID1);
+		final var	c2	= getContactByID(contactID2);
+
+		// Remove users from each others contact list
+		c1.getContacts().remove(c2);
+		c2.getContacts().remove(c1);
+
+		// Synchronize changes with the database
+		transaction(() -> { entityManager.merge(c1); entityManager.merge(c2); });
+	}
+
 	/**
 	 * @param user the User whose contacts should be retrieved
 	 * @return the contacts of this User
diff --git a/server/src/main/java/envoy/server/data/User.java b/server/src/main/java/envoy/server/data/User.java
index e4c0829..9c45801 100755
--- a/server/src/main/java/envoy/server/data/User.java
+++ b/server/src/main/java/envoy/server/data/User.java
@@ -70,6 +70,9 @@ public final class User extends Contact {
 	@Column(name = "last_seen")
 	private Instant lastSeen;
 
+	@Column(name = "latest_contact_deletion")
+	private Instant latestContactDeletion;
+
 	private UserStatus status;
 
 	@Override
@@ -140,4 +143,16 @@ public final class User extends Contact {
 	 * @since Envoy Server Standalone v0.1-alpha
 	 */
 	public void setStatus(UserStatus status) { this.status = status; }
+
+	/**
+	 * @return the latestContactDeletion
+	 * @since Envoy Server v0.3-beta
+	 */
+	public Instant getLatestContactDeletion() { return latestContactDeletion; }
+
+	/**
+	 * @param latestContactDeletion the latestContactDeletion to set
+	 * @since Envoy Server v0.3-beta
+	 */
+	public void setLatestContactDeletion(Instant latestContactDeletion) { this.latestContactDeletion = latestContactDeletion; }
 }
diff --git a/server/src/main/java/envoy/server/processors/ContactOperationProcessor.java b/server/src/main/java/envoy/server/processors/ContactOperationProcessor.java
index 178bff4..8049ed6 100755
--- a/server/src/main/java/envoy/server/processors/ContactOperationProcessor.java
+++ b/server/src/main/java/envoy/server/processors/ContactOperationProcessor.java
@@ -1,10 +1,11 @@
 package envoy.server.processors;
 
-import java.util.logging.Logger;
+import java.time.Instant;
+import java.util.logging.*;
 
 import envoy.event.ElementOperation;
 import envoy.event.contact.ContactOperation;
-import envoy.server.data.PersistenceManager;
+import envoy.server.data.*;
 import envoy.server.net.*;
 import envoy.util.EnvoyLog;
 
@@ -14,23 +15,55 @@ import envoy.util.EnvoyLog;
  */
 public final class ContactOperationProcessor implements ObjectProcessor<ContactOperation> {
 
-	private static final ConnectionManager connectionManager = ConnectionManager.getInstance();
+	private static final ConnectionManager	connectionManager	= ConnectionManager.getInstance();
 	private static final Logger				logger				= EnvoyLog.getLogger(ContactOperationProcessor.class);
+	private static final PersistenceManager	persistenceManager	= PersistenceManager.getInstance();
 
 	@Override
 	public void process(ContactOperation evt, long socketId, ObjectWriteProxy writeProxy) {
+		final long	userID		= ConnectionManager.getInstance().getUserIDBySocketID(socketId);
+		final long	contactID	= evt.get().getID();
+		final var	sender		= persistenceManager.getUserByID(userID);
 		switch (evt.getOperationType()) {
 			case ADD:
-				final long userID = ConnectionManager.getInstance().getUserIDBySocketID(socketId);
-				final long contactId = evt.get().getID();
-
-				logger.fine(String.format("Adding user %s to the contact list of user %d.%n", evt.get(), userID));
-				PersistenceManager.getInstance().addContactBidirectional(userID, contactId);
+				logger.log(Level.FINE, String.format("Adding %s to the contact list of user %d.", evt.get(), userID));
+				persistenceManager.addContactBidirectional(userID, contactID);
 
 				// Notify the contact if online
-				if (ConnectionManager.getInstance().isOnline(contactId))
-					writeProxy.write(connectionManager.getSocketID(contactId),
-							new ContactOperation(PersistenceManager.getInstance().getUserByID(userID).toCommon(), ElementOperation.ADD));
+				if (connectionManager.isOnline(contactID))
+					writeProxy.write(connectionManager.getSocketID(contactID), new ContactOperation(sender.toCommon(), ElementOperation.ADD));
+				break;
+			case REMOVE:
+
+				// Remove the relationships and notify sender if he logs in using another
+				// LocalDB
+				persistenceManager.removeContactBidirectional(userID, contactID);
+				final var contact = persistenceManager.getContactByID(contactID);
+				sender.setLatestContactDeletion(Instant.now());
+
+				// The sender wants to remove a normal contact
+				if (contact instanceof User) {
+
+					// Notify the removed contact on next startup(s) of this deletion
+					persistenceManager.getUserByID(contactID).setLatestContactDeletion(Instant.now());
+
+					// Notify the removed contact if online
+					if (connectionManager.isOnline(contactID))
+						writeProxy.write(connectionManager.getSocketID(contactID), new ContactOperation(sender.toCommon(), ElementOperation.REMOVE));
+				} else {
+
+					// The sender wants to be removed from a Group
+					final var group = persistenceManager.getGroupByID(contactID);
+
+					// The group has no more members and hence will be deleted
+					if (group.getContacts().isEmpty()) persistenceManager.deleteContact(group);
+					else {
+
+						// Informing the other members
+						writeProxy.writeToOnlineContacts(group.getContacts(), new ContactOperation(sender.toCommon(), ElementOperation.REMOVE));
+						group.getContacts().forEach(c -> ((User) c).setLatestContactDeletion(Instant.now()));
+					}
+				}
 				break;
 			default:
 				logger.warning(String.format("Received %s with an unsupported operation.", evt));
diff --git a/server/src/main/java/envoy/server/processors/LoginCredentialProcessor.java b/server/src/main/java/envoy/server/processors/LoginCredentialProcessor.java
index 3e91a7f..2526de3 100755
--- a/server/src/main/java/envoy/server/processors/LoginCredentialProcessor.java
+++ b/server/src/main/java/envoy/server/processors/LoginCredentialProcessor.java
@@ -13,6 +13,7 @@ import javax.persistence.NoResultException;
 
 import envoy.data.LoginCredentials;
 import envoy.event.*;
+import envoy.event.contact.ContactDeletionSinceLastLogin;
 import envoy.server.data.*;
 import envoy.server.net.*;
 import envoy.server.util.*;
@@ -104,6 +105,7 @@ public final class LoginCredentialProcessor implements ObjectProcessor<LoginCred
 				user.setStatus(ONLINE);
 				user.setPasswordHash(PasswordUtil.hash(credentials.getPassword()));
 				user.setContacts(new HashSet<>());
+				user.setLatestContactDeletion(Instant.EPOCH);
 				persistenceManager.addContact(user);
 				logger.info("Registered new " + user);
 			}
@@ -208,5 +210,8 @@ public final class LoginCredentialProcessor implements ObjectProcessor<LoginCred
 
 		// Complete the handshake
 		writeProxy.write(socketID, user.toCommon());
+
+		// Notify the user if a contact deletion has happened since he last logged in
+		if (user.getLatestContactDeletion().isAfter(user.getLastSeen())) writeProxy.write(socketID, new ContactDeletionSinceLastLogin());
 	}
 }
-- 
2.30.2


From 7bdcfad08c982a93116be2e3aef6075257c18f01 Mon Sep 17 00:00:00 2001
From: delvh <leon@kske.dev>
Date: Sun, 11 Oct 2020 23:04:25 +0200
Subject: [PATCH 2/6] Add partially working blocking and deletion (for both
 client and server)

Additionally had to refactor several classes "a little bit".
(Whenever one bug seemed fixed, another one appeared...)
---
 .../src/main/java/envoy/client/data/Chat.java |  20 +++
 .../java/envoy/client/data/GroupChat.java     |   2 +-
 .../main/java/envoy/client/data/LocalDB.java  |  59 ++++++++-
 .../main/java/envoy/client/net/Client.java    |  29 ++++-
 .../main/java/envoy/client/ui/Startup.java    |   2 +-
 .../envoy/client/ui/control/ChatControl.java  |   4 +-
 .../envoy/client/ui/controller/ChatScene.java | 121 ++++++++++++++----
 .../ui/controller/ContactSearchTab.java       |   6 +-
 .../ui/controller/GroupCreationTab.java       |   6 +-
 .../main/java/envoy/client/util/UserUtil.java |  62 ++++++++-
 client/src/main/resources/css/base.css        |  19 ++-
 client/src/main/resources/fxml/ChatScene.fxml |   2 +-
 .../main/java/envoy/event/GroupCreation.java  |   6 +-
 .../java/envoy/event/GroupCreationResult.java |  18 ++-
 .../main/java/envoy/event/GroupResize.java    |  15 +--
 ...ava => ContactsChangedSinceLastLogin.java} |   2 +-
 ...ntactOperation.java => UserOperation.java} |  17 ++-
 .../processors/ContactOperationProcessor.java |  12 +-
 .../processors/GroupCreationProcessor.java    |  11 +-
 .../processors/LoginCredentialProcessor.java  |   7 +-
 20 files changed, 326 insertions(+), 94 deletions(-)
 rename common/src/main/java/envoy/event/contact/{ContactDeletionSinceLastLogin.java => ContactsChangedSinceLastLogin.java} (82%)
 rename common/src/main/java/envoy/event/contact/{ContactOperation.java => UserOperation.java} (56%)

diff --git a/client/src/main/java/envoy/client/data/Chat.java b/client/src/main/java/envoy/client/data/Chat.java
index 80b2a97..ba40bbe 100644
--- a/client/src/main/java/envoy/client/data/Chat.java
+++ b/client/src/main/java/envoy/client/data/Chat.java
@@ -27,6 +27,8 @@ public class Chat implements Serializable {
 
 	protected int unreadAmount;
 
+	private boolean disabled;
+
 	/**
 	 * Stores the last time an {@link envoy.event.IsTyping} event has been sent.
 	 */
@@ -168,4 +170,22 @@ public class Chat implements Serializable {
 	 * @since Envoy Client v0.2-beta
 	 */
 	public void lastWritingEventWasNow() { lastWritingEvent = System.currentTimeMillis(); }
+
+	/**
+	 * Determines whether messages can be sent in this chat. Should be true i.e. for
+	 * chats whose recipient deleted this client as a contact.
+	 *
+	 * @return whether this {@code Chat} has been disabled
+	 * @since Envoy Client v0.3-beta
+	 */
+	public boolean isDisabled() { return disabled; }
+
+	/**
+	 * Determines whether messages can be sent in this chat. Should be true i.e. for
+	 * chats whose recipient deleted this client as a contact.
+	 *
+	 * @param disabled the disabled to set
+	 * @since Envoy Client v0.3-beta
+	 */
+	public void setDisabled(boolean disabled) { this.disabled = disabled; }
 }
diff --git a/client/src/main/java/envoy/client/data/GroupChat.java b/client/src/main/java/envoy/client/data/GroupChat.java
index 188709c..049c32e 100644
--- a/client/src/main/java/envoy/client/data/GroupChat.java
+++ b/client/src/main/java/envoy/client/data/GroupChat.java
@@ -25,7 +25,7 @@ public final class GroupChat extends Chat {
 	 * @param recipient the group whose members receive the messages
 	 * @since Envoy Client v0.1-beta
 	 */
-	public GroupChat(User sender, Contact recipient) {
+	public GroupChat(User sender, Group recipient) {
 		super(recipient);
 		this.sender = sender;
 	}
diff --git a/client/src/main/java/envoy/client/data/LocalDB.java b/client/src/main/java/envoy/client/data/LocalDB.java
index 13db9df..691a878 100644
--- a/client/src/main/java/envoy/client/data/LocalDB.java
+++ b/client/src/main/java/envoy/client/data/LocalDB.java
@@ -14,6 +14,7 @@ import envoy.client.event.*;
 import envoy.data.*;
 import envoy.data.Message.MessageStatus;
 import envoy.event.*;
+import envoy.event.contact.*;
 import envoy.exception.EnvoyException;
 import envoy.util.*;
 
@@ -34,11 +35,12 @@ public final class LocalDB implements EventListener {
 
 	// Data
 	private User					user;
-	private Map<String, User>		users		= Collections.synchronizedMap(new HashMap<>());
-	private ObservableList<Chat>	chats		= FXCollections.observableArrayList();
+	private Map<String, User>		users				= Collections.synchronizedMap(new HashMap<>());
+	private ObservableList<Chat>	chats				= FXCollections.observableArrayList();
 	private IDGenerator				idGenerator;
-	private CacheMap				cacheMap	= new CacheMap();
+	private CacheMap				cacheMap			= new CacheMap();
 	private String					authToken;
+	private Set<? extends Contact>	originalContacts	= Set.of();
 
 	// Auto save timer
 	private Timer	autoSaver;
@@ -163,7 +165,7 @@ public final class LocalDB implements EventListener {
 		user.getContacts()
 			.stream()
 			.filter(c -> !c.equals(user) && getChat(c.getID()).isEmpty())
-			.map(c -> c instanceof User ? new Chat(c) : new GroupChat(user, c))
+			.map(c -> c instanceof User ? new Chat(c) : new GroupChat(user, (Group) c))
 			.forEach(chats::add);
 	}
 
@@ -197,7 +199,7 @@ public final class LocalDB implements EventListener {
 	 */
 	@Event(eventType = EnvoyCloseEvent.class, priority = 1000)
 	private synchronized void save() {
-		EnvoyLog.getLogger(LocalDB.class).log(Level.INFO, "Saving local database...");
+		EnvoyLog.getLogger(LocalDB.class).log(Level.FINER, "Saving local database...");
 
 		// Save users
 		try {
@@ -240,6 +242,31 @@ public final class LocalDB implements EventListener {
 		getChat(evt.getID()).map(Chat::getRecipient).map(User.class::cast).ifPresent(u -> u.setStatus(evt.get()));
 	}
 
+	@Event(priority = 200)
+	private void onUserOperation(UserOperation operation) {
+		final var eventUser = operation.get();
+		switch (operation.getOperationType()) {
+			case ADD:
+				getUsers().put(eventUser.getName(), eventUser);
+				Platform.runLater(() -> chats.add(0, new Chat(eventUser)));
+				break;
+			case REMOVE:
+				getChat(eventUser.getID()).ifPresent(chat -> chat.setDisabled(true));
+				break;
+		}
+	}
+
+	@Event
+	private void onGroupCreationResult(GroupCreationResult evt) {
+		final var newGroup = evt.get();
+
+		// The group creation was not successful
+		if (newGroup == null) return;
+
+		// The group was successfully created
+		else Platform.runLater(() -> chats.add(new GroupChat(user, newGroup)));
+	}
+
 	@Event(priority = 150)
 	private void onGroupResize(GroupResize evt) { getChat(evt.getGroupID()).map(Chat::getRecipient).map(Group.class::cast).ifPresent(evt::apply); }
 
@@ -296,6 +323,9 @@ public final class LocalDB implements EventListener {
 	@Event(priority = 500)
 	private void onOwnStatusChange(OwnStatusChange statusChange) { user.setStatus(statusChange.get()); }
 
+	@Event(eventType = ContactsChangedSinceLastLogin.class, priority = 500)
+	private void onContactsChangedSinceLastLogin() { if (user != null) originalContacts = user.getContacts(); }
+
 	/**
 	 * @return a {@code Map<String, User>} of all users stored locally with their
 	 *         user names as keys
@@ -323,6 +353,25 @@ public final class LocalDB implements EventListener {
 	 */
 	public Optional<Chat> getChat(long recipientID) { return chats.stream().filter(c -> c.getRecipient().getID() == recipientID).findAny(); }
 
+	/**
+	 * Sets the given user as base of this {@code LocalDB}.
+	 * Additionally compares his contacts with the ones returned by the server, in
+	 * case they might have been deleted.
+	 *
+	 * @param user the user to set
+	 * @since Envoy Client v0.2-alpha
+	 */
+	public void setUserAndMergeContacts(User user) {
+		this.user = user;
+		if (originalContacts.isEmpty()) return;
+		else {
+
+			// mark all chats of deleted contacts
+			originalContacts.removeAll(user.getContacts());
+			originalContacts.forEach(contact -> getChat(contact.getID()).ifPresent(chat -> chat.setDisabled(true)));
+		}
+	}
+
 	/**
 	 * @return all saved {@link Chat} objects that list the client user as the
 	 *         sender
diff --git a/client/src/main/java/envoy/client/net/Client.java b/client/src/main/java/envoy/client/net/Client.java
index 0db43ef..e84388d 100644
--- a/client/src/main/java/envoy/client/net/Client.java
+++ b/client/src/main/java/envoy/client/net/Client.java
@@ -9,6 +9,7 @@ import envoy.client.data.*;
 import envoy.client.event.EnvoyCloseEvent;
 import envoy.data.*;
 import envoy.event.*;
+import envoy.event.contact.ContactsChangedSinceLastLogin;
 import envoy.util.*;
 
 import dev.kske.eventbus.*;
@@ -29,6 +30,7 @@ public final class Client implements EventListener, Closeable {
 	private Socket		socket;
 	private Receiver	receiver;
 	private boolean		online;
+	private boolean		isHandShake;
 
 	// Asynchronously initialized during handshake
 	private volatile User		sender;
@@ -61,6 +63,7 @@ public final class Client implements EventListener, Closeable {
 	 */
 	public void performHandshake(LoginCredentials credentials, CacheMap cacheMap) throws TimeoutException, IOException, InterruptedException {
 		if (online) throw new IllegalStateException("Handshake has already been performed successfully");
+		isHandShake = true;
 
 		// Establish TCP connection
 		logger.log(Level.FINER, String.format("Attempting connection to server %s:%d...", config.getServer(), config.getPort()));
@@ -92,14 +95,19 @@ public final class Client implements EventListener, Closeable {
 			if (rejected) {
 				socket.close();
 				receiver.removeAllProcessors();
+				isHandShake = false;
 				return;
 			}
 
-			if (System.currentTimeMillis() - start > 5000) throw new TimeoutException("Did not log in after 5 seconds");
+			if (System.currentTimeMillis() - start > 5000) {
+				isHandShake = false;
+				throw new TimeoutException("Did not log in after 5 seconds");
+			}
 			Thread.sleep(500);
 		}
 
-		online = true;
+		online		= true;
+		isHandShake	= false;
 		logger.log(Level.INFO, "Handshake completed.");
 	}
 
@@ -146,7 +154,7 @@ public final class Client implements EventListener, Closeable {
 		logger.log(Level.FINE, "Sending " + obj);
 		try {
 			SerializationUtils.writeBytesWithLength(obj, socket.getOutputStream());
-		} catch (IOException e) {
+		} catch (final IOException e) {
 			throw new RuntimeException(e);
 		}
 	}
@@ -174,7 +182,20 @@ public final class Client implements EventListener, Closeable {
 	}
 
 	@Event(eventType = HandshakeRejection.class, priority = 1000)
-	private void onHandshakeRejection() { rejected = true; }
+	private void onHandshakeRejection() {
+		rejected	= true;
+		isHandShake	= false;
+	}
+
+	@Event(eventType = ContactsChangedSinceLastLogin.class, priority = 1000)
+	private void onContactsChangedSinceLastLogin() {
+		if (!isHandShake) {
+			logger.log(Level.WARNING, "Received a request to check contacts while not in the handshake");
+
+			// TODO: consume event once event consumption is implemented
+			return;
+		}
+	}
 
 	@Override
 	@Event(eventType = EnvoyCloseEvent.class, priority = 800)
diff --git a/client/src/main/java/envoy/client/ui/Startup.java b/client/src/main/java/envoy/client/ui/Startup.java
index a93bf81..cd4ddbc 100644
--- a/client/src/main/java/envoy/client/ui/Startup.java
+++ b/client/src/main/java/envoy/client/ui/Startup.java
@@ -179,7 +179,7 @@ public final class Startup extends Application {
 
 		// Set client user in local database
 		final var user = client.getSender();
-		localDB.setUser(user);
+		localDB.setUserAndMergeContacts(user);
 
 		// Initialize chats in local database
 		try {
diff --git a/client/src/main/java/envoy/client/ui/control/ChatControl.java b/client/src/main/java/envoy/client/ui/control/ChatControl.java
index 353bdaf..6d4b535 100644
--- a/client/src/main/java/envoy/client/ui/control/ChatControl.java
+++ b/client/src/main/java/envoy/client/ui/control/ChatControl.java
@@ -59,6 +59,8 @@ public final class ChatControl extends HBox {
 			vbox.getChildren().add(unreadMessagesLabel);
 			getChildren().add(vbox);
 		}
-		getStyleClass().add("list-element");
+
+		// Set background depending on whether it is disabled or not
+		getStyleClass().add(chat.isDisabled() ? "disabled-chat" : "list-element");
 	}
 }
diff --git a/client/src/main/java/envoy/client/ui/controller/ChatScene.java b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
index 4103a5b..4c98c76 100644
--- a/client/src/main/java/envoy/client/ui/controller/ChatScene.java
+++ b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
@@ -37,7 +37,7 @@ import envoy.data.*;
 import envoy.data.Attachment.AttachmentType;
 import envoy.data.Message.MessageStatus;
 import envoy.event.*;
-import envoy.event.contact.ContactOperation;
+import envoy.event.contact.UserOperation;
 import envoy.exception.EnvoyException;
 import envoy.util.EnvoyLog;
 
@@ -270,18 +270,22 @@ public final class ChatScene implements EventListener, Restorable {
 	}
 
 	@Event
-	private void onContactOperation(ContactOperation operation) {
-		final var contact = operation.get();
-		switch (operation.getOperationType()) {
-			case ADD:
-				if (contact instanceof User) localDB.getUsers().put(contact.getName(), (User) contact);
-				final var chat = contact instanceof User ? new Chat(contact) : new GroupChat(client.getSender(), contact);
-				Platform.runLater(() -> ((ObservableList<Chat>) chats.getSource()).add(0, chat));
-				break;
-			case REMOVE:
-				Platform.runLater(() -> chats.getSource().removeIf(c -> c.getRecipient().equals(contact)));
-				break;
-		}
+	private void onUserOperation(UserOperation operation) {
+		// All ADD dependant logic resides in LocalDB
+		if (operation.getOperationType().equals(ElementOperation.REMOVE))
+			if (currentChat != null && currentChat.getRecipient().equals(operation.get())) Platform.runLater(this::resetState);
+	}
+
+	@Event
+	private void onGroupResize(GroupResize resize) {
+		final var chatFound = localDB.getChat(resize.getGroupID());
+		Platform.runLater(() -> {
+			chatList.refresh();
+
+			// Update the top-bar status label if all conditions apply
+			if (currentChat != null && currentChat.getRecipient().equals(chatFound.get().getRecipient()))
+				chatFound.ifPresent(chat -> topBarStatusLabel.setText(chat.getRecipient().getContacts().size() + " members"));
+		});
 	}
 
 	@Event(eventType = NoAttachments.class)
@@ -297,8 +301,8 @@ public final class ChatScene implements EventListener, Restorable {
 		});
 	}
 
-	@Event
-	private void onGroupCreationResult(GroupCreationResult result) { Platform.runLater(() -> newGroupButton.setDisable(!result.get())); }
+	@Event(priority = 150)
+	private void onGroupCreationResult(GroupCreationResult result) { Platform.runLater(() -> newGroupButton.setDisable(result.get() == null)); }
 
 	@Event(eventType = ThemeChangeEvent.class)
 	private void onThemeChange() {
@@ -311,7 +315,6 @@ public final class ChatScene implements EventListener, Restorable {
 		clientProfilePic.setImage(IconUtil.loadIconThemeSensitive("user_icon", 43));
 		chatList.setCellFactory(new ListCellFactory<>(ChatControl::new));
 		messageList.setCellFactory(MessageListCell::new);
-		// TODO: cache image
 		if (currentChat != null)
 			if (currentChat.getRecipient() instanceof User) recipientProfilePic.setImage(IconUtil.loadIconThemeSensitive("user_icon", 43));
 			else recipientProfilePic.setImage(IconUtil.loadIconThemeSensitive("group_icon", 43));
@@ -330,9 +333,11 @@ public final class ChatScene implements EventListener, Restorable {
 	 */
 	@FXML
 	private void chatListClicked() {
-		if (chatList.getSelectionModel().isEmpty()) return;
+		if (currentChat != null && chatList.getSelectionModel().isEmpty()) return;
+		final var chat = chatList.getSelectionModel().getSelectedItem();
+		if (chat == null) return;
 
-		final var user = chatList.getSelectionModel().getSelectedItem().getRecipient();
+		final var user = chat.getRecipient();
 		if (user != null && (currentChat == null || !user.equals(currentChat.getRecipient()))) {
 
 			// LEON: JFC <===> JAVA FRIED CHICKEN <=/=> Java Foundation Classes
@@ -362,17 +367,24 @@ public final class ChatScene implements EventListener, Restorable {
 			remainingChars
 				.setText(String.format("remaining chars: %d/%d", MAX_MESSAGE_LENGTH - messageTextArea.getText().length(), MAX_MESSAGE_LENGTH));
 		}
-		messageTextArea.setDisable(currentChat == null || postingPermanentlyDisabled);
-		voiceButton.setDisable(!recorder.isSupported());
-		attachmentButton.setDisable(false);
+
+		// Enable or disable the necessary UI controls
+		final var chatEditable = currentChat == null || currentChat.isDisabled();
+		messageTextArea.setDisable(chatEditable || postingPermanentlyDisabled);
+		voiceButton.setDisable(!recorder.isSupported() || chatEditable);
+		attachmentButton.setDisable(chatEditable);
 		chatList.refresh();
 
+		// Design the top bar
 		if (currentChat != null) {
 			topBarContactLabel.setText(currentChat.getRecipient().getName());
+			topBarContactLabel.setVisible(true);
 			if (currentChat.getRecipient() instanceof User) {
 				final var status = ((User) currentChat.getRecipient()).getStatus().toString();
 				topBarStatusLabel.setText(status);
+				topBarStatusLabel.getStyleClass().clear();
 				topBarStatusLabel.getStyleClass().add(status.toLowerCase());
+				topBarStatusLabel.setVisible(true);
 				recipientProfilePic.setImage(IconUtil.loadIconThemeSensitive("user_icon", 43));
 			} else {
 				topBarStatusLabel.setText(currentChat.getRecipient().getContacts().size() + " members");
@@ -385,8 +397,11 @@ public final class ChatScene implements EventListener, Restorable {
 			clip.setArcHeight(43);
 			clip.setArcWidth(43);
 			recipientProfilePic.setClip(clip);
-
+			messageList.getStyleClass().clear();
 			messageSearchButton.setVisible(true);
+
+			// Change the background of the message list if the chat is disabled
+			if (currentChat.isDisabled()) messageList.getStyleClass().add("disabled-chat");
 		}
 	}
 
@@ -664,9 +679,9 @@ public final class ChatScene implements EventListener, Restorable {
 			Platform.runLater(() -> {
 				chats.getSource().remove(currentChat);
 				((ObservableList<Chat>) chats.getSource()).add(0, currentChat);
-				chatList.getSelectionModel().select(0);
 				localDB.getChats().remove(currentChat);
 				localDB.getChats().add(0, currentChat);
+				chatList.getSelectionModel().select(0);
 			});
 			scrollToMessageListEnd();
 
@@ -711,7 +726,8 @@ public final class ChatScene implements EventListener, Restorable {
 	 * @since Envoy Client v0.1-beta
 	 */
 	private void updateAttachmentView(boolean visible) {
-		if (!attachmentView.getImage().equals(DEFAULT_ATTACHMENT_VIEW_IMAGE)) attachmentView.setImage(DEFAULT_ATTACHMENT_VIEW_IMAGE);
+		if (!(attachmentView.getImage() == null || attachmentView.getImage().equals(DEFAULT_ATTACHMENT_VIEW_IMAGE)))
+			attachmentView.setImage(DEFAULT_ATTACHMENT_VIEW_IMAGE);
 		attachmentView.setVisible(visible);
 	}
 
@@ -734,7 +750,62 @@ public final class ChatScene implements EventListener, Restorable {
 	// Context menu actions
 
 	@FXML
-	private void deleteContact() { try {} catch (final NullPointerException e) {} }
+	private void blockOrDeleteContact() {
+		final var selectedChat = chatList.getSelectionModel().getSelectedItem();
+
+		if (selectedChat == null) return;
+		// If a contact has already been blocked deletes this chat else only blocks him
+		if (selectedChat.isDisabled()) UserUtil.deleteContact(selectedChat.getRecipient());
+		else UserUtil.blockContact(selectedChat.getRecipient());
+	}
+
+	/**
+	 * Redesigns the UI when the {@link Chat} of the given contact has been marked
+	 * as disabled.
+	 *
+	 * @param recipient       the contact whose chat got disabled
+	 * @param refreshChatList whether to refresh the chatList
+	 * @since Envoy Client v0.3-beta
+	 */
+	public void disableChat(Contact recipient, boolean refreshChatList) {
+		if (refreshChatList) chatList.refresh();
+		if (currentChat != null && currentChat.getRecipient().equals(recipient)) {
+			messageTextArea.setDisable(true);
+			voiceButton.setDisable(true);
+			attachmentButton.setDisable(true);
+			pendingAttachment = null;
+			messageList.getStyleClass().clear();
+			messageList.getStyleClass().add("disabled-chat");
+		}
+	}
+
+	/**
+	 * Resets every component back to its inital state before a chat was selected.
+	 *
+	 * @since Envoy Client v0.3-beta
+	 */
+	public void resetState() {
+		currentChat = null;
+		chatList.getSelectionModel().clearSelection();
+		messageList.getItems().clear();
+		messageTextArea.setDisable(true);
+		attachmentView.setImage(null);
+		topBarContactLabel.setVisible(false);
+		topBarStatusLabel.setVisible(false);
+		messageSearchButton.setVisible(false);
+		messageTextArea.clear();
+		messageTextArea.setDisable(true);
+		attachmentButton.setDisable(true);
+		voiceButton.setDisable(true);
+		remainingChars.setVisible(false);
+		pendingAttachment = null;
+		recipientProfilePic.setImage(null);
+
+		// It is a valid case that cancel can cause a NullPointerException
+		try {
+			recorder.cancel();
+		} catch (final NullPointerException e) {}
+	}
 
 	@FXML
 	private void copyAndPostMessage() {
diff --git a/client/src/main/java/envoy/client/ui/controller/ContactSearchTab.java b/client/src/main/java/envoy/client/ui/controller/ContactSearchTab.java
index b573345..380c549 100644
--- a/client/src/main/java/envoy/client/ui/controller/ContactSearchTab.java
+++ b/client/src/main/java/envoy/client/ui/controller/ContactSearchTab.java
@@ -63,7 +63,7 @@ public class ContactSearchTab implements EventListener {
 	}
 
 	@Event
-	private void onContactOperation(ContactOperation operation) {
+	private void onUserOperation(UserOperation operation) {
 		final var contact = operation.get();
 		if (operation.getOperationType() == ElementOperation.ADD) Platform.runLater(() -> {
 			userList.getItems().remove(contact);
@@ -96,7 +96,7 @@ public class ContactSearchTab implements EventListener {
 	}
 
 	/**
-	 * Sends an {@link ContactOperation} for the selected user to the
+	 * Sends an {@link UserOperation} for the selected user to the
 	 * server.
 	 *
 	 * @since Envoy Client v0.1-beta
@@ -114,7 +114,7 @@ public class ContactSearchTab implements EventListener {
 	private void addAsContact() {
 
 		// Sends the event to the server
-		final var event = new ContactOperation(currentlySelectedUser, ElementOperation.ADD);
+		final var event = new UserOperation(currentlySelectedUser, ElementOperation.ADD);
 		client.send(event);
 
 		// Removes the chosen user and updates the UI
diff --git a/client/src/main/java/envoy/client/ui/controller/GroupCreationTab.java b/client/src/main/java/envoy/client/ui/controller/GroupCreationTab.java
index 23ec485..d262214 100644
--- a/client/src/main/java/envoy/client/ui/controller/GroupCreationTab.java
+++ b/client/src/main/java/envoy/client/ui/controller/GroupCreationTab.java
@@ -16,7 +16,7 @@ import envoy.client.ui.control.*;
 import envoy.client.ui.listcell.ListCellFactory;
 import envoy.data.*;
 import envoy.event.GroupCreation;
-import envoy.event.contact.ContactOperation;
+import envoy.event.contact.UserOperation;
 import envoy.util.Bounds;
 
 import dev.kske.eventbus.*;
@@ -234,8 +234,8 @@ public class GroupCreationTab implements EventListener {
 	}
 
 	@Event
-	private void onContactOperation(ContactOperation operation) {
-		if (operation.get() instanceof User) Platform.runLater(() -> {
+	private void onUserOperation(UserOperation operation) {
+		Platform.runLater(() -> {
 			switch (operation.getOperationType()) {
 				case ADD:
 					userList.getItems().add((User) operation.get());
diff --git a/client/src/main/java/envoy/client/util/UserUtil.java b/client/src/main/java/envoy/client/util/UserUtil.java
index 4f1b37b..dc34455 100644
--- a/client/src/main/java/envoy/client/util/UserUtil.java
+++ b/client/src/main/java/envoy/client/util/UserUtil.java
@@ -5,12 +5,15 @@ import java.util.logging.Level;
 import javafx.scene.control.Alert;
 import javafx.scene.control.Alert.AlertType;
 
-import envoy.client.data.Context;
+import envoy.client.data.*;
 import envoy.client.event.*;
 import envoy.client.helper.*;
 import envoy.client.ui.SceneContext.SceneInfo;
+import envoy.client.ui.controller.ChatScene;
+import envoy.data.*;
 import envoy.data.User.UserStatus;
-import envoy.event.UserStatusChange;
+import envoy.event.*;
+import envoy.event.contact.UserOperation;
 import envoy.util.EnvoyLog;
 
 import dev.kske.eventbus.EventBus;
@@ -23,6 +26,8 @@ import dev.kske.eventbus.EventBus;
  */
 public final class UserUtil {
 
+	private static final Context context = Context.getInstance();
+
 	private UserUtil() {}
 
 	/**
@@ -40,7 +45,7 @@ public final class UserUtil {
 			EnvoyLog.getLogger(ShutdownHelper.class).log(Level.INFO, "A logout was requested");
 			EventBus.getInstance().dispatch(new EnvoyCloseEvent());
 			EventBus.getInstance().dispatch(new Logout());
-			Context.getInstance().getSceneContext().load(SceneInfo.LOGIN_SCENE);
+			context.getSceneContext().load(SceneInfo.LOGIN_SCENE);
 		});
 	}
 
@@ -54,11 +59,56 @@ public final class UserUtil {
 	public static void changeStatus(UserStatus newStatus) {
 
 		// Sending the already active status is a valid action
-		if (newStatus.equals(Context.getInstance().getLocalDB().getUser().getStatus())) return;
+		if (newStatus.equals(context.getLocalDB().getUser().getStatus())) return;
 		else {
 			EventBus.getInstance().dispatch(new OwnStatusChange(newStatus));
-			if (Context.getInstance().getClient().isOnline())
-				Context.getInstance().getClient().send(new UserStatusChange(Context.getInstance().getLocalDB().getUser().getID(), newStatus));
+			if (context.getClient().isOnline()) context.getClient().send(new UserStatusChange(context.getLocalDB().getUser().getID(), newStatus));
+		}
+	}
+
+	/**
+	 * Removes the given contact. Should not be confused with the method that is
+	 * called when the server reports that a contact has been deleted while the user
+	 * was offline.
+	 *
+	 * @param block the contact that should be removed
+	 * @since Envoy Client v0.3-beta
+	 * @see LocalDB#setUserAndMergeContacts(envoy.data.User)
+	 */
+	public static void blockContact(Contact block) {
+		if (!context.getClient().isOnline() || block == null) return;
+		else {
+			final var alert = new Alert(AlertType.CONFIRMATION);
+			alert.setContentText("Are you sure you want to block " + block.getName() + "?");
+			AlertHelper.confirmAction(alert, () -> {
+				context.getClient()
+					.send(block instanceof User ? new UserOperation((User) block, ElementOperation.REMOVE)
+							: new GroupResize(context.getLocalDB().getUser(), (Group) block, ElementOperation.REMOVE));
+				context.getLocalDB().getChat(block.getID()).ifPresent(chat -> chat.setDisabled(true));
+				final var controller = context.getSceneContext().getController();
+				if (controller instanceof ChatScene) ((ChatScene) controller).disableChat(block, true);
+			});
+		}
+	}
+
+	/**
+	 * Deletes the given contact with all his messages entirely.
+	 *
+	 * @param delete the contact to delete
+	 * @since Envoy Client v0.3-beta
+	 */
+	public static void deleteContact(Contact delete) {
+		if (!context.getClient().isOnline() || delete == null) return;
+		else {
+			final var alert = new Alert(AlertType.CONFIRMATION);
+			alert.setContentText("Are you sure you want to delete " + delete.getName()
+					+ " entirely? All messages with this contact will be deleted. This action cannot be undone.");
+			AlertHelper.confirmAction(alert, () -> {
+				context.getLocalDB().getUsers().remove(delete.getName());
+				context.getLocalDB().getChats().removeIf(chat -> chat.getRecipient().equals(delete));
+				if (context.getSceneContext().getController() instanceof ChatScene)
+					((ChatScene) context.getSceneContext().getController()).resetState();
+			});
 		}
 	}
 }
diff --git a/client/src/main/resources/css/base.css b/client/src/main/resources/css/base.css
index 28d276c..bfe4da2 100644
--- a/client/src/main/resources/css/base.css
+++ b/client/src/main/resources/css/base.css
@@ -139,20 +139,25 @@
 
 .tab-pane {
     -fx-tab-max-height: 0.0 ;
-} 
+}
+
 .tab-pane .tab-header-area {
     visibility: hidden ;
     -fx-padding: -20.0 0.0 0.0 0.0;
 }
 
+.disabled-chat {
+	-fx-background-color: #F04000;
+}
+
 #quick-select-list .scroll-bar:horizontal{
-	-fx-pref-height: 0;
-	-fx-max-height: 0;
-	-fx-min-height: 0; 
+	-fx-pref-height: 0.0;
+	-fx-max-height: 0.0;
+	-fx-min-height: 0.0; 
 }
 
 #quick-select-list .scroll-bar:vertical{
-	-fx-pref-width: 0;
-	-fx-max-width: 0;
-	-fx-min-width: 0; 
+	-fx-pref-width: 0.0;
+	-fx-max-width: 0.0;
+	-fx-min-width: 0.0; 
 }
diff --git a/client/src/main/resources/fxml/ChatScene.fxml b/client/src/main/resources/fxml/ChatScene.fxml
index 8221f19..8368e4b 100644
--- a/client/src/main/resources/fxml/ChatScene.fxml
+++ b/client/src/main/resources/fxml/ChatScene.fxml
@@ -130,7 +130,7 @@
 												<ContextMenu anchorLocation="CONTENT_TOP_LEFT">
 													<items>
 														<MenuItem fx:id="deleteContactMenuItem"
-															mnemonicParsing="false" onAction="#deleteContact"
+															mnemonicParsing="false" onAction="#blockOrDeleteContact"
 															text="Delete" />
 													</items>
 												</ContextMenu>
diff --git a/common/src/main/java/envoy/event/GroupCreation.java b/common/src/main/java/envoy/event/GroupCreation.java
index 02270ee..ffd7851 100644
--- a/common/src/main/java/envoy/event/GroupCreation.java
+++ b/common/src/main/java/envoy/event/GroupCreation.java
@@ -17,14 +17,14 @@ public final class GroupCreation extends Event<String> {
 	private static final long serialVersionUID = 0L;
 
 	/**
-	 * @param value            the name of this group at creation time
+	 * @param name             the name of this group at creation time
 	 * @param initialMemberIDs the IDs of all {@link User}s that should be group
 	 *                         members from the beginning on (excluding the creator
 	 *                         of this group)
 	 * @since Envoy Common v0.1-beta
 	 */
-	public GroupCreation(String value, Set<Long> initialMemberIDs) {
-		super(value);
+	public GroupCreation(String name, Set<Long> initialMemberIDs) {
+		super(name);
 		this.initialMemberIDs = initialMemberIDs != null ? initialMemberIDs : new HashSet<>();
 	}
 
diff --git a/common/src/main/java/envoy/event/GroupCreationResult.java b/common/src/main/java/envoy/event/GroupCreationResult.java
index 3944ec2..14ae2f6 100644
--- a/common/src/main/java/envoy/event/GroupCreationResult.java
+++ b/common/src/main/java/envoy/event/GroupCreationResult.java
@@ -1,5 +1,7 @@
 package envoy.event;
 
+import envoy.data.Group;
+
 /**
  * Used to communicate with a client that his request to create a group might
  * have been rejected as it might be disabled on his current server.
@@ -7,15 +9,23 @@ package envoy.event;
  * @author Leon Hofmeister
  * @since Envoy Common v0.2-beta
  */
-public class GroupCreationResult extends Event<Boolean> {
+public class GroupCreationResult extends Event<Group> {
 
 	private static final long serialVersionUID = 1L;
 
 	/**
-	 * Creates a new {@code GroupCreationResult}.
+	 * Creates a new {@code GroupCreationResult} that implies the failure of this
+	 * {@link GroupCreationResult}.
 	 *
-	 * @param success whether the GroupCreation sent before was successful
 	 * @since Envoy Common v0.2-beta
 	 */
-	public GroupCreationResult(boolean success) { super(success); }
+	public GroupCreationResult() { super(null); }
+
+	/**
+	 * Creates a new {@code GroupCreationResult}.
+	 *
+	 * @param resultGroup the group the server created
+	 * @since Envoy Common v0.2-beta
+	 */
+	public GroupCreationResult(Group resultGroup) { super(resultGroup); }
 }
diff --git a/common/src/main/java/envoy/event/GroupResize.java b/common/src/main/java/envoy/event/GroupResize.java
index c8e8c76..4df5f97 100644
--- a/common/src/main/java/envoy/event/GroupResize.java
+++ b/common/src/main/java/envoy/event/GroupResize.java
@@ -33,13 +33,12 @@ public final class GroupResize extends Event<User> {
 	 */
 	public GroupResize(User user, Group group, ElementOperation operation) {
 		super(user);
-		this.operation	= operation;
-		if (group.getContacts().contains(user)) {
-			if (operation.equals(ADD))
-				throw new IllegalArgumentException(String.format("Cannot add %s to %s!", user, group));
-		} else if (operation.equals(REMOVE))
-			throw new IllegalArgumentException(String.format("Cannot remove %s from %s!", user, group));
-		groupID	= group.getID();
+		this.operation = operation;
+		final var contained = group.getContacts().contains(user);
+		if (contained && operation.equals(ADD))
+			throw new IllegalArgumentException(String.format("Cannot add %s to %s!", user, group));
+		else if (operation.equals(REMOVE) && !contained) throw new IllegalArgumentException(String.format("Cannot remove %s from %s!", user, group));
+		groupID = group.getID();
 	}
 
 	/**
@@ -72,5 +71,5 @@ public final class GroupResize extends Event<User> {
 	}
 
 	@Override
-	public String toString() { return String.format("GroupResize[userid=%d,groupid=%d,operation=%s]", get(), groupID, operation); }
+	public String toString() { return String.format("GroupResize[user=%s,groupid=%d,operation=%s]", get(), groupID, operation); }
 }
diff --git a/common/src/main/java/envoy/event/contact/ContactDeletionSinceLastLogin.java b/common/src/main/java/envoy/event/contact/ContactsChangedSinceLastLogin.java
similarity index 82%
rename from common/src/main/java/envoy/event/contact/ContactDeletionSinceLastLogin.java
rename to common/src/main/java/envoy/event/contact/ContactsChangedSinceLastLogin.java
index cda2483..f8734e8 100644
--- a/common/src/main/java/envoy/event/contact/ContactDeletionSinceLastLogin.java
+++ b/common/src/main/java/envoy/event/contact/ContactsChangedSinceLastLogin.java
@@ -9,7 +9,7 @@ import envoy.event.Event.Valueless;
  * @author Leon Hofmeister
  * @since Envoy Common v0.3-beta
  */
-public class ContactDeletionSinceLastLogin extends Valueless {
+public class ContactsChangedSinceLastLogin extends Valueless {
 
 	private static final long serialVersionUID = 1L;
 }
diff --git a/common/src/main/java/envoy/event/contact/ContactOperation.java b/common/src/main/java/envoy/event/contact/UserOperation.java
similarity index 56%
rename from common/src/main/java/envoy/event/contact/ContactOperation.java
rename to common/src/main/java/envoy/event/contact/UserOperation.java
index a31d147..666183e 100644
--- a/common/src/main/java/envoy/event/contact/ContactOperation.java
+++ b/common/src/main/java/envoy/event/contact/UserOperation.java
@@ -1,35 +1,38 @@
 package envoy.event.contact;
 
-import envoy.data.Contact;
+import envoy.data.User;
 import envoy.event.*;
 
 /**
  * Signifies the modification of a contact list.
  *
  * @author Maximilian K&auml;fer
- * @since Envoy Common v0.2-alpha
+ * @since Envoy Common v0.3-beta
  */
-public final class ContactOperation extends Event<Contact> {
+public final class UserOperation extends Event<User> {
 
 	private final ElementOperation operationType;
 
 	private static final long serialVersionUID = 1L;
 
 	/**
-	 * Initializes a {@link ContactOperation}.
+	 * Initializes a {@link UserOperation}.
 	 *
 	 * @param contact       the user on which the operation is performed
 	 * @param operationType the type of operation to perform
-	 * @since Envoy Common v0.2-alpha
+	 * @since Envoy Common v0.3-beta
 	 */
-	public ContactOperation(Contact contact, ElementOperation operationType) {
+	public UserOperation(User contact, ElementOperation operationType) {
 		super(contact);
 		this.operationType = operationType;
 	}
 
 	/**
 	 * @return the type of operation to perform
-	 * @since Envoy Common v0.2-alpha
+	 * @since Envoy Common v0.3-beta
 	 */
 	public ElementOperation getOperationType() { return operationType; }
+
+	@Override
+	public String toString() { return String.format("%s[contact=%s, operation=%s]", UserOperation.class.getSimpleName(), value, operationType); }
 }
diff --git a/server/src/main/java/envoy/server/processors/ContactOperationProcessor.java b/server/src/main/java/envoy/server/processors/ContactOperationProcessor.java
index 8049ed6..1fa74fb 100755
--- a/server/src/main/java/envoy/server/processors/ContactOperationProcessor.java
+++ b/server/src/main/java/envoy/server/processors/ContactOperationProcessor.java
@@ -4,7 +4,7 @@ import java.time.Instant;
 import java.util.logging.*;
 
 import envoy.event.ElementOperation;
-import envoy.event.contact.ContactOperation;
+import envoy.event.contact.UserOperation;
 import envoy.server.data.*;
 import envoy.server.net.*;
 import envoy.util.EnvoyLog;
@@ -13,14 +13,14 @@ import envoy.util.EnvoyLog;
  * @author Kai S. K. Engelbart
  * @since Envoy Server Standalone v0.1-alpha
  */
-public final class ContactOperationProcessor implements ObjectProcessor<ContactOperation> {
+public final class ContactOperationProcessor implements ObjectProcessor<UserOperation> {
 
 	private static final ConnectionManager	connectionManager	= ConnectionManager.getInstance();
 	private static final Logger				logger				= EnvoyLog.getLogger(ContactOperationProcessor.class);
 	private static final PersistenceManager	persistenceManager	= PersistenceManager.getInstance();
 
 	@Override
-	public void process(ContactOperation evt, long socketId, ObjectWriteProxy writeProxy) {
+	public void process(UserOperation evt, long socketId, ObjectWriteProxy writeProxy) {
 		final long	userID		= ConnectionManager.getInstance().getUserIDBySocketID(socketId);
 		final long	contactID	= evt.get().getID();
 		final var	sender		= persistenceManager.getUserByID(userID);
@@ -31,7 +31,7 @@ public final class ContactOperationProcessor implements ObjectProcessor<ContactO
 
 				// Notify the contact if online
 				if (connectionManager.isOnline(contactID))
-					writeProxy.write(connectionManager.getSocketID(contactID), new ContactOperation(sender.toCommon(), ElementOperation.ADD));
+					writeProxy.write(connectionManager.getSocketID(contactID), new UserOperation(sender.toCommon(), ElementOperation.ADD));
 				break;
 			case REMOVE:
 
@@ -49,7 +49,7 @@ public final class ContactOperationProcessor implements ObjectProcessor<ContactO
 
 					// Notify the removed contact if online
 					if (connectionManager.isOnline(contactID))
-						writeProxy.write(connectionManager.getSocketID(contactID), new ContactOperation(sender.toCommon(), ElementOperation.REMOVE));
+						writeProxy.write(connectionManager.getSocketID(contactID), new UserOperation(sender.toCommon(), ElementOperation.REMOVE));
 				} else {
 
 					// The sender wants to be removed from a Group
@@ -60,7 +60,7 @@ public final class ContactOperationProcessor implements ObjectProcessor<ContactO
 					else {
 
 						// Informing the other members
-						writeProxy.writeToOnlineContacts(group.getContacts(), new ContactOperation(sender.toCommon(), ElementOperation.REMOVE));
+						writeProxy.writeToOnlineContacts(group.getContacts(), new UserOperation(sender.toCommon(), ElementOperation.REMOVE));
 						group.getContacts().forEach(c -> ((User) c).setLatestContactDeletion(Instant.now()));
 					}
 				}
diff --git a/server/src/main/java/envoy/server/processors/GroupCreationProcessor.java b/server/src/main/java/envoy/server/processors/GroupCreationProcessor.java
index 8f40af2..3540238 100644
--- a/server/src/main/java/envoy/server/processors/GroupCreationProcessor.java
+++ b/server/src/main/java/envoy/server/processors/GroupCreationProcessor.java
@@ -5,7 +5,6 @@ import static envoy.server.Startup.config;
 import java.util.HashSet;
 
 import envoy.event.*;
-import envoy.event.contact.ContactOperation;
 import envoy.server.data.*;
 import envoy.server.net.*;
 
@@ -21,8 +20,10 @@ public final class GroupCreationProcessor implements ObjectProcessor<GroupCreati
 	@Override
 	public void process(GroupCreation groupCreation, long socketID, ObjectWriteProxy writeProxy) {
 		// Don't allow the creation of groups if manually disabled
-		writeProxy.write(socketID, new GroupCreationResult(config.isGroupSupportEnabled()));
-		if (!config.isGroupSupportEnabled()) return;
+		if (!config.isGroupSupportEnabled()) {
+			writeProxy.write(socketID, new GroupCreationResult());
+			return;
+		}
 		final envoy.server.data.Group group = new envoy.server.data.Group();
 		group.setName(groupCreation.get());
 		group.setContacts(new HashSet<>());
@@ -31,11 +32,13 @@ public final class GroupCreationProcessor implements ObjectProcessor<GroupCreati
 		group.getContacts().forEach(c -> c.getContacts().add(group));
 		group.getContacts().add(persistenceManager.getUserByID(connectionManager.getUserIDBySocketID(socketID)));
 		persistenceManager.addContact(group);
+		final var resultGroup = group.toCommon();
 		group.getContacts()
 			.stream()
 			.map(Contact::getID)
 			.filter(connectionManager::isOnline)
 			.map(connectionManager::getSocketID)
-			.forEach(memberSocketID -> writeProxy.write(memberSocketID, new ContactOperation(group.toCommon(), ElementOperation.ADD)));
+			.forEach(memberSocketID -> writeProxy.write(memberSocketID, new GroupCreationResult(resultGroup)));
+		writeProxy.write(socketID, new GroupCreationResult(resultGroup));
 	}
 }
diff --git a/server/src/main/java/envoy/server/processors/LoginCredentialProcessor.java b/server/src/main/java/envoy/server/processors/LoginCredentialProcessor.java
index 2526de3..ba484db 100755
--- a/server/src/main/java/envoy/server/processors/LoginCredentialProcessor.java
+++ b/server/src/main/java/envoy/server/processors/LoginCredentialProcessor.java
@@ -13,7 +13,7 @@ import javax.persistence.NoResultException;
 
 import envoy.data.LoginCredentials;
 import envoy.event.*;
-import envoy.event.contact.ContactDeletionSinceLastLogin;
+import envoy.event.contact.ContactsChangedSinceLastLogin;
 import envoy.server.data.*;
 import envoy.server.net.*;
 import envoy.server.util.*;
@@ -207,11 +207,10 @@ public final class LoginCredentialProcessor implements ObjectProcessor<LoginCred
 					writeProxy.write(socketID, new MessageStatusChange(gmsgCommon));
 			}
 		}
+		// Notify the user if a contact deletion has happened since he last logged in
+		if (user.getLatestContactDeletion().isAfter(user.getLastSeen())) writeProxy.write(socketID, new ContactsChangedSinceLastLogin());
 
 		// Complete the handshake
 		writeProxy.write(socketID, user.toCommon());
-
-		// Notify the user if a contact deletion has happened since he last logged in
-		if (user.getLatestContactDeletion().isAfter(user.getLastSeen())) writeProxy.write(socketID, new ContactDeletionSinceLastLogin());
 	}
 }
-- 
2.30.2


From a91181b4dd6d6062fe712af897be4837937d4c36 Mon Sep 17 00:00:00 2001
From: delvh <leon@kske.dev>
Date: Tue, 13 Oct 2020 23:51:02 +0200
Subject: [PATCH 3/6] Fix several bugs

These are:
- not immediately updating ChatScene if a contact was blocked and both
are online
- ContactSearchTab showing previously entered text on reopening (without
showing suggestions)
- users not getting notified if someone else blocked them while they
were offline
- no logger statements in UserUtil

Still to do:
- Move ContextMenu from chatList to ChatControl
- Test behavior for groups
---
 .../src/main/java/envoy/client/data/Chat.java |  4 +-
 .../main/java/envoy/client/data/LocalDB.java  | 39 +++++++++++++------
 .../envoy/client/ui/controller/ChatScene.java |  3 +-
 .../ui/controller/ContactSearchTab.java       |  5 ++-
 .../ui/controller/GroupCreationTab.java       |  6 +--
 .../main/java/envoy/client/util/UserUtil.java |  9 ++++-
 6 files changed, 45 insertions(+), 21 deletions(-)

diff --git a/client/src/main/java/envoy/client/data/Chat.java b/client/src/main/java/envoy/client/data/Chat.java
index ba40bbe..d8b2ee8 100644
--- a/client/src/main/java/envoy/client/data/Chat.java
+++ b/client/src/main/java/envoy/client/data/Chat.java
@@ -57,7 +57,9 @@ public class Chat implements Serializable {
 	}
 
 	@Override
-	public String toString() { return String.format("%s[recipient=%s,messages=%d]", getClass().getSimpleName(), recipient, messages.size()); }
+	public String toString() {
+		return String.format("%s[recipient=%s,messages=%d, disabled=%b]", getClass().getSimpleName(), recipient, messages.size(), disabled);
+	}
 
 	/**
 	 * Generates a hash code based on the recipient.
diff --git a/client/src/main/java/envoy/client/data/LocalDB.java b/client/src/main/java/envoy/client/data/LocalDB.java
index 691a878..28b7ccd 100644
--- a/client/src/main/java/envoy/client/data/LocalDB.java
+++ b/client/src/main/java/envoy/client/data/LocalDB.java
@@ -1,11 +1,14 @@
 package envoy.client.data;
 
+import static java.util.function.Predicate.not;
+
 import java.io.*;
 import java.nio.channels.*;
 import java.nio.file.StandardOpenOption;
 import java.time.Instant;
 import java.util.*;
 import java.util.logging.*;
+import java.util.stream.Stream;
 
 import javafx.application.Platform;
 import javafx.collections.*;
@@ -35,12 +38,13 @@ public final class LocalDB implements EventListener {
 
 	// Data
 	private User					user;
-	private Map<String, User>		users				= Collections.synchronizedMap(new HashMap<>());
-	private ObservableList<Chat>	chats				= FXCollections.observableArrayList();
+	private Map<String, User>		users		= Collections.synchronizedMap(new HashMap<>());
+	private ObservableList<Chat>	chats		= FXCollections.observableArrayList();
 	private IDGenerator				idGenerator;
-	private CacheMap				cacheMap			= new CacheMap();
+	private CacheMap				cacheMap	= new CacheMap();
 	private String					authToken;
-	private Set<? extends Contact>	originalContacts	= Set.of();
+	private boolean					contactsChanged;
+	private Stream<Chat>			changedChats;
 
 	// Auto save timer
 	private Timer	autoSaver;
@@ -138,7 +142,19 @@ public final class LocalDB implements EventListener {
 		if (user == null) throw new IllegalStateException("Client user is null, cannot initialize user storage");
 		userFile = new File(dbDir, user.getID() + ".db");
 		try (var in = new ObjectInputStream(new FileInputStream(userFile))) {
-			chats		= FXCollections.observableList((List<Chat>) in.readObject());
+			chats = FXCollections.observableList((List<Chat>) in.readObject());
+
+			// Some chats have changed and should not be overridden by the saved values
+			if (changedChats != null) {
+				changedChats.forEach(chat -> {
+					final var chatIndex = chats.indexOf(chat);
+					if (chatIndex == -1) return;
+					else chats.set(chatIndex, chat);
+				});
+
+				// loadUserData can get called two (or more?) times during application lifecycle
+				changedChats = null;
+			}
 			cacheMap	= (CacheMap) in.readObject();
 			lastSync	= (Instant) in.readObject();
 		} finally {
@@ -324,7 +340,7 @@ public final class LocalDB implements EventListener {
 	private void onOwnStatusChange(OwnStatusChange statusChange) { user.setStatus(statusChange.get()); }
 
 	@Event(eventType = ContactsChangedSinceLastLogin.class, priority = 500)
-	private void onContactsChangedSinceLastLogin() { if (user != null) originalContacts = user.getContacts(); }
+	private void onContactsChangedSinceLastLogin() { if (user != null) contactsChanged = true; }
 
 	/**
 	 * @return a {@code Map<String, User>} of all users stored locally with their
@@ -363,13 +379,12 @@ public final class LocalDB implements EventListener {
 	 */
 	public void setUserAndMergeContacts(User user) {
 		this.user = user;
-		if (originalContacts.isEmpty()) return;
-		else {
+		if (contactsChanged)
 
-			// mark all chats of deleted contacts
-			originalContacts.removeAll(user.getContacts());
-			originalContacts.forEach(contact -> getChat(contact.getID()).ifPresent(chat -> chat.setDisabled(true)));
-		}
+			// Mark chats as disabled if a contact is no longer in this users contact list
+			changedChats = chats.stream()
+				.filter(not(chat -> user.getContacts().contains(chat.getRecipient())))
+				.peek(chat -> { chat.setDisabled(true); logger.log(Level.INFO, String.format("Marked %s as blocked.", chat.getRecipient())); });
 	}
 
 	/**
diff --git a/client/src/main/java/envoy/client/ui/controller/ChatScene.java b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
index 4c98c76..ca845ed 100644
--- a/client/src/main/java/envoy/client/ui/controller/ChatScene.java
+++ b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
@@ -272,8 +272,7 @@ public final class ChatScene implements EventListener, Restorable {
 	@Event
 	private void onUserOperation(UserOperation operation) {
 		// All ADD dependant logic resides in LocalDB
-		if (operation.getOperationType().equals(ElementOperation.REMOVE))
-			if (currentChat != null && currentChat.getRecipient().equals(operation.get())) Platform.runLater(this::resetState);
+		if (operation.getOperationType().equals(ElementOperation.REMOVE)) Platform.runLater(() -> disableChat(operation.get(), true));
 	}
 
 	@Event
diff --git a/client/src/main/java/envoy/client/ui/controller/ContactSearchTab.java b/client/src/main/java/envoy/client/ui/controller/ContactSearchTab.java
index 380c549..a31b664 100644
--- a/client/src/main/java/envoy/client/ui/controller/ContactSearchTab.java
+++ b/client/src/main/java/envoy/client/ui/controller/ContactSearchTab.java
@@ -124,5 +124,8 @@ public class ContactSearchTab implements EventListener {
 	}
 
 	@FXML
-	private void backButtonClicked() { eventBus.dispatch(new BackEvent()); }
+	private void backButtonClicked() {
+		searchBar.setText("");
+		eventBus.dispatch(new BackEvent());
+	}
 }
diff --git a/client/src/main/java/envoy/client/ui/controller/GroupCreationTab.java b/client/src/main/java/envoy/client/ui/controller/GroupCreationTab.java
index d262214..ce085a7 100644
--- a/client/src/main/java/envoy/client/ui/controller/GroupCreationTab.java
+++ b/client/src/main/java/envoy/client/ui/controller/GroupCreationTab.java
@@ -82,7 +82,7 @@ public class GroupCreationTab implements EventListener {
 				.map(User.class::cast)
 				.collect(Collectors.toList()));
 		resizeQuickSelectSpace(0);
-		quickSelectList.addEventFilter(MouseEvent.MOUSE_PRESSED, evt -> evt.consume());
+		quickSelectList.addEventFilter(MouseEvent.MOUSE_PRESSED, MouseEvent::consume);
 	}
 
 	/**
@@ -169,7 +169,7 @@ public class GroupCreationTab implements EventListener {
 
 	/**
 	 * Removes an element from the quickSelectList.
-	 * 
+	 *
 	 * @param element the element to be removed.
 	 * @since Envoy Client v0.3-beta
 	 */
@@ -238,7 +238,7 @@ public class GroupCreationTab implements EventListener {
 		Platform.runLater(() -> {
 			switch (operation.getOperationType()) {
 				case ADD:
-					userList.getItems().add((User) operation.get());
+					userList.getItems().add(operation.get());
 					break;
 				case REMOVE:
 					userList.getItems().removeIf(operation.get()::equals);
diff --git a/client/src/main/java/envoy/client/util/UserUtil.java b/client/src/main/java/envoy/client/util/UserUtil.java
index dc34455..8e38ae3 100644
--- a/client/src/main/java/envoy/client/util/UserUtil.java
+++ b/client/src/main/java/envoy/client/util/UserUtil.java
@@ -1,6 +1,6 @@
 package envoy.client.util;
 
-import java.util.logging.Level;
+import java.util.logging.*;
 
 import javafx.scene.control.Alert;
 import javafx.scene.control.Alert.AlertType;
@@ -26,7 +26,8 @@ import dev.kske.eventbus.EventBus;
  */
 public final class UserUtil {
 
-	private static final Context context = Context.getInstance();
+	private static final Context	context	= Context.getInstance();
+	private static final Logger		logger	= EnvoyLog.getLogger(UserUtil.class);
 
 	private UserUtil() {}
 
@@ -46,6 +47,7 @@ public final class UserUtil {
 			EventBus.getInstance().dispatch(new EnvoyCloseEvent());
 			EventBus.getInstance().dispatch(new Logout());
 			context.getSceneContext().load(SceneInfo.LOGIN_SCENE);
+			logger.log(Level.INFO, "A logout occurred.");
 		});
 	}
 
@@ -63,6 +65,7 @@ public final class UserUtil {
 		else {
 			EventBus.getInstance().dispatch(new OwnStatusChange(newStatus));
 			if (context.getClient().isOnline()) context.getClient().send(new UserStatusChange(context.getLocalDB().getUser().getID(), newStatus));
+			logger.log(Level.INFO, "A manual status change occurred.");
 		}
 	}
 
@@ -87,6 +90,7 @@ public final class UserUtil {
 				context.getLocalDB().getChat(block.getID()).ifPresent(chat -> chat.setDisabled(true));
 				final var controller = context.getSceneContext().getController();
 				if (controller instanceof ChatScene) ((ChatScene) controller).disableChat(block, true);
+				logger.log(Level.INFO, "A contact was blocked.");
 			});
 		}
 	}
@@ -108,6 +112,7 @@ public final class UserUtil {
 				context.getLocalDB().getChats().removeIf(chat -> chat.getRecipient().equals(delete));
 				if (context.getSceneContext().getController() instanceof ChatScene)
 					((ChatScene) context.getSceneContext().getController()).resetState();
+				logger.log(Level.INFO, "A contact with all his messages was deleted.");
 			});
 		}
 	}
-- 
2.30.2


From bdb964a0d1360448108a6f22460d0116bede0de9 Mon Sep 17 00:00:00 2001
From: delvh <leon@kske.dev>
Date: Wed, 14 Oct 2020 23:41:24 +0200
Subject: [PATCH 4/6] Move context menu from ChatScene globally to ChatControl
 specific

Additionally fixed a small bug in UserCreationProcessor and when
deleting a contact offline
---
 .../envoy/client/ui/control/ChatControl.java  | 31 ++++++++----
 .../envoy/client/ui/controller/ChatScene.java | 19 +-------
 .../main/java/envoy/client/util/UserUtil.java |  2 +-
 client/src/main/resources/fxml/ChatScene.fxml |  9 ----
 .../src/main/java/envoy/server/Startup.java   |  2 +-
 .../envoy/server/data/PersistenceManager.java | 48 ++++++++++++++-----
 .../processors/GroupCreationProcessor.java    | 18 +++----
 ...essor.java => UserOperationProcessor.java} | 36 ++++----------
 8 files changed, 76 insertions(+), 89 deletions(-)
 rename server/src/main/java/envoy/server/processors/{ContactOperationProcessor.java => UserOperationProcessor.java} (51%)

diff --git a/client/src/main/java/envoy/client/ui/control/ChatControl.java b/client/src/main/java/envoy/client/ui/control/ChatControl.java
index 6d4b535..c42ec28 100644
--- a/client/src/main/java/envoy/client/ui/control/ChatControl.java
+++ b/client/src/main/java/envoy/client/ui/control/ChatControl.java
@@ -1,12 +1,13 @@
 package envoy.client.ui.control;
 
 import javafx.geometry.*;
-import javafx.scene.control.Label;
+import javafx.scene.control.*;
 import javafx.scene.image.Image;
 import javafx.scene.layout.*;
 
 import envoy.client.data.*;
-import envoy.client.util.IconUtil;
+import envoy.client.util.*;
+import envoy.data.User;
 
 /**
  * Displays a chat using a contact control for the recipient and a label for the
@@ -16,7 +17,7 @@ import envoy.client.util.IconUtil;
  * @author Leon Hofmeister
  * @since Envoy Client v0.1-beta
  */
-public final class ChatControl extends HBox {
+public final class ChatControl extends Label {
 
 	private static final Image userIcon = IconUtil.loadIconThemeSensitive("user_icon", 32),
 			groupIcon = IconUtil.loadIconThemeSensitive("group_icon", 32);
@@ -31,25 +32,35 @@ public final class ChatControl extends HBox {
 		setAlignment(Pos.CENTER_LEFT);
 		setPadding(new Insets(0, 0, 3, 0));
 
+		final var	menu		= new ContextMenu();
+		final var	removeMI	= new MenuItem();
+		removeMI
+			.setText(chat.isDisabled() ? "Delete " : chat.getRecipient() instanceof User ? "Block " : "Leave group " + chat.getRecipient().getName());
+		removeMI.setOnAction(chat.isDisabled() ? e -> UserUtil.deleteContact(chat.getRecipient()) : e -> UserUtil.blockContact(chat.getRecipient()));
+		menu.getItems().add(removeMI);
+		setContextMenu(menu);
+
+		final var display = new HBox();
+
 		// Profile picture
 		final var contactProfilePic = new ProfilePicImageView(chat instanceof GroupChat ? groupIcon : userIcon, 32);
-		getChildren().add(contactProfilePic);
+		display.getChildren().add(contactProfilePic);
 
 		// Spacing
 		final var leftSpacing = new Region();
 		leftSpacing.setPrefSize(8, 0);
 		leftSpacing.setMinSize(8, 0);
 		leftSpacing.setMaxSize(8, 0);
-		getChildren().add(leftSpacing);
+		display.getChildren().add(leftSpacing);
 
 		// Contact control
-		getChildren().add(new ContactControl(chat.getRecipient()));
+		display.getChildren().add(new ContactControl(chat.getRecipient()));
 
 		// Unread messages
 		if (chat.getUnreadAmount() != 0) {
 			final var spacing = new Region();
-			setHgrow(spacing, Priority.ALWAYS);
-			getChildren().add(spacing);
+			HBox.setHgrow(spacing, Priority.ALWAYS);
+			display.getChildren().add(spacing);
 			final var unreadMessagesLabel = new Label(Integer.toString(chat.getUnreadAmount()));
 			unreadMessagesLabel.setMinSize(15, 15);
 			final var vbox = new VBox();
@@ -57,9 +68,11 @@ public final class ChatControl extends HBox {
 			unreadMessagesLabel.setAlignment(Pos.CENTER);
 			unreadMessagesLabel.getStyleClass().add("unread-messages-amount");
 			vbox.getChildren().add(unreadMessagesLabel);
-			getChildren().add(vbox);
+			display.getChildren().add(vbox);
 		}
 
+		setGraphic(display);
+
 		// Set background depending on whether it is disabled or not
 		getStyleClass().add(chat.isDisabled() ? "disabled-chat" : "list-element");
 	}
diff --git a/client/src/main/java/envoy/client/ui/controller/ChatScene.java b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
index ca845ed..b28e428 100644
--- a/client/src/main/java/envoy/client/ui/controller/ChatScene.java
+++ b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
@@ -91,9 +91,6 @@ public final class ChatScene implements EventListener, Restorable {
 	@FXML
 	private Label topBarStatusLabel;
 
-	@FXML
-	private MenuItem deleteContactMenuItem;
-
 	@FXML
 	private ImageView attachmentView;
 
@@ -278,12 +275,13 @@ public final class ChatScene implements EventListener, Restorable {
 	@Event
 	private void onGroupResize(GroupResize resize) {
 		final var chatFound = localDB.getChat(resize.getGroupID());
+		if (chatFound.isEmpty()) return;
 		Platform.runLater(() -> {
 			chatList.refresh();
 
 			// Update the top-bar status label if all conditions apply
 			if (currentChat != null && currentChat.getRecipient().equals(chatFound.get().getRecipient()))
-				chatFound.ifPresent(chat -> topBarStatusLabel.setText(chat.getRecipient().getContacts().size() + " members"));
+				topBarStatusLabel.setText(chatFound.get().getRecipient().getContacts().size() + " members");
 		});
 	}
 
@@ -348,7 +346,6 @@ public final class ChatScene implements EventListener, Restorable {
 			final var scrollIndex = messageList.getItems().size() - currentChat.getUnreadAmount();
 			messageList.scrollTo(scrollIndex);
 			logger.log(Level.FINEST, "Loading chat with " + user + " at index " + scrollIndex);
-			deleteContactMenuItem.setText("Delete " + user.getName());
 
 			// Read the current chat
 			currentChat.read(writeProxy);
@@ -746,18 +743,6 @@ public final class ChatScene implements EventListener, Restorable {
 		}
 	}
 
-	// Context menu actions
-
-	@FXML
-	private void blockOrDeleteContact() {
-		final var selectedChat = chatList.getSelectionModel().getSelectedItem();
-
-		if (selectedChat == null) return;
-		// If a contact has already been blocked deletes this chat else only blocks him
-		if (selectedChat.isDisabled()) UserUtil.deleteContact(selectedChat.getRecipient());
-		else UserUtil.blockContact(selectedChat.getRecipient());
-	}
-
 	/**
 	 * Redesigns the UI when the {@link Chat} of the given contact has been marked
 	 * as disabled.
diff --git a/client/src/main/java/envoy/client/util/UserUtil.java b/client/src/main/java/envoy/client/util/UserUtil.java
index 8e38ae3..c6477b1 100644
--- a/client/src/main/java/envoy/client/util/UserUtil.java
+++ b/client/src/main/java/envoy/client/util/UserUtil.java
@@ -102,7 +102,7 @@ public final class UserUtil {
 	 * @since Envoy Client v0.3-beta
 	 */
 	public static void deleteContact(Contact delete) {
-		if (!context.getClient().isOnline() || delete == null) return;
+		if (delete == null) return;
 		else {
 			final var alert = new Alert(AlertType.CONFIRMATION);
 			alert.setContentText("Are you sure you want to delete " + delete.getName()
diff --git a/client/src/main/resources/fxml/ChatScene.fxml b/client/src/main/resources/fxml/ChatScene.fxml
index 8368e4b..d61325c 100644
--- a/client/src/main/resources/fxml/ChatScene.fxml
+++ b/client/src/main/resources/fxml/ChatScene.fxml
@@ -126,15 +126,6 @@
 										<ListView id="chat-list" fx:id="chatList"
 											focusTraversable="false" onMouseClicked="#chatListClicked"
 											prefWidth="316.0" VBox.vgrow="ALWAYS">
-											<contextMenu>
-												<ContextMenu anchorLocation="CONTENT_TOP_LEFT">
-													<items>
-														<MenuItem fx:id="deleteContactMenuItem"
-															mnemonicParsing="false" onAction="#blockOrDeleteContact"
-															text="Delete" />
-													</items>
-												</ContextMenu>
-											</contextMenu>
 											<padding>
 												<Insets bottom="5.0" left="5.0" right="2.0" top="5.0" />
 											</padding>
diff --git a/server/src/main/java/envoy/server/Startup.java b/server/src/main/java/envoy/server/Startup.java
index 6beafee..db890ac 100755
--- a/server/src/main/java/envoy/server/Startup.java
+++ b/server/src/main/java/envoy/server/Startup.java
@@ -51,7 +51,7 @@ public final class Startup {
 						new UserStatusChangeProcessor(),
 						new IDGeneratorRequestProcessor(),
 						new UserSearchProcessor(),
-						new ContactOperationProcessor(),
+						new UserOperationProcessor(),
 						new IsTypingProcessor(),
 						new NameChangeProcessor(),
 						new ProfilePicChangeProcessor(),
diff --git a/server/src/main/java/envoy/server/data/PersistenceManager.java b/server/src/main/java/envoy/server/data/PersistenceManager.java
index 9350569..2c9bf33 100755
--- a/server/src/main/java/envoy/server/data/PersistenceManager.java
+++ b/server/src/main/java/envoy/server/data/PersistenceManager.java
@@ -2,11 +2,13 @@ package envoy.server.data;
 
 import java.time.Instant;
 import java.util.List;
+import java.util.logging.Level;
 
 import javax.persistence.*;
 
 import envoy.data.User.UserStatus;
 import envoy.server.net.ConnectionManager;
+import envoy.util.EnvoyLog;
 
 /**
  * Contains operations used for persistence.
@@ -240,17 +242,24 @@ public final class PersistenceManager {
 	 * @since Envoy Server Standalone v0.1-alpha
 	 */
 	public void addContactBidirectional(long contactID1, long contactID2) {
+		addContactBidirectional(getContactByID(contactID1), getContactByID(contactID2));
+	}
 
-		// Get users by ID
-		final var	c1	= getContactByID(contactID1);
-		final var	c2	= getContactByID(contactID2);
+	/**
+	 * Adds a contact to the contact list of another contact and vice versa.
+	 *
+	 * @param contact1 the first contact
+	 * @param contact2 the second contact
+	 * @since Envoy Server v0.3-beta
+	 */
+	public void addContactBidirectional(Contact contact1, Contact contact2) {
 
 		// Add users to each others contact list
-		c1.getContacts().add(c2);
-		c2.getContacts().add(c1);
+		contact1.getContacts().add(contact2);
+		contact2.getContacts().add(contact1);
 
 		// Synchronize changes with the database
-		transaction(() -> { entityManager.merge(c1); entityManager.merge(c2); });
+		transaction(() -> { entityManager.merge(contact1); entityManager.merge(contact2); });
 	}
 
 	/**
@@ -261,17 +270,24 @@ public final class PersistenceManager {
 	 * @since Envoy Server v0.3-beta
 	 */
 	public void removeContactBidirectional(long contactID1, long contactID2) {
+		removeContactBidirectional(getContactByID(contactID1), getContactByID(contactID2));
+	}
 
-		// Get users by ID
-		final var	c1	= getContactByID(contactID1);
-		final var	c2	= getContactByID(contactID2);
+	/**
+	 * Removes a contact from the contact list of another contact and vice versa.
+	 *
+	 * @param contact1 the first contact
+	 * @param contact2 the second contact
+	 * @since Envoy Server v0.3-beta
+	 */
+	public void removeContactBidirectional(Contact contact1, Contact contact2) {
 
 		// Remove users from each others contact list
-		c1.getContacts().remove(c2);
-		c2.getContacts().remove(c1);
+		contact1.getContacts().remove(contact2);
+		contact2.getContacts().remove(contact1);
 
 		// Synchronize changes with the database
-		transaction(() -> { entityManager.merge(c1); entityManager.merge(c2); });
+		transaction(() -> { entityManager.merge(contact1); entityManager.merge(contact2); });
 	}
 
 	/**
@@ -311,6 +327,14 @@ public final class PersistenceManager {
 				entityManagerRelatedAction.run();
 				transaction.commit();
 			}
+		} catch (final RollbackException e2) {
+
+			// Apparently a major problem exists. Discard faulty transaction and then go on.
+			if (transaction.isActive()) {
+				transaction.rollback();
+				EnvoyLog.getLogger(PersistenceManager.class)
+					.log(Level.SEVERE, "Could not perform transaction, hence discarding it. It's likely that a serious issue exists.");
+			} else throw e2;
 		}
 	}
 }
diff --git a/server/src/main/java/envoy/server/processors/GroupCreationProcessor.java b/server/src/main/java/envoy/server/processors/GroupCreationProcessor.java
index 3540238..28ec8f7 100644
--- a/server/src/main/java/envoy/server/processors/GroupCreationProcessor.java
+++ b/server/src/main/java/envoy/server/processors/GroupCreationProcessor.java
@@ -5,7 +5,7 @@ import static envoy.server.Startup.config;
 import java.util.HashSet;
 
 import envoy.event.*;
-import envoy.server.data.*;
+import envoy.server.data.PersistenceManager;
 import envoy.server.net.*;
 
 /**
@@ -27,18 +27,12 @@ public final class GroupCreationProcessor implements ObjectProcessor<GroupCreati
 		final envoy.server.data.Group group = new envoy.server.data.Group();
 		group.setName(groupCreation.get());
 		group.setContacts(new HashSet<>());
-		groupCreation.getInitialMemberIDs().stream().map(persistenceManager::getUserByID).forEach(group.getContacts()::add);
-		group.getContacts().add(persistenceManager.getContactByID(connectionManager.getUserIDBySocketID(socketID)));
-		group.getContacts().forEach(c -> c.getContacts().add(group));
-		group.getContacts().add(persistenceManager.getUserByID(connectionManager.getUserIDBySocketID(socketID)));
 		persistenceManager.addContact(group);
-		final var resultGroup = group.toCommon();
-		group.getContacts()
+		groupCreation.getInitialMemberIDs()
 			.stream()
-			.map(Contact::getID)
-			.filter(connectionManager::isOnline)
-			.map(connectionManager::getSocketID)
-			.forEach(memberSocketID -> writeProxy.write(memberSocketID, new GroupCreationResult(resultGroup)));
-		writeProxy.write(socketID, new GroupCreationResult(resultGroup));
+			.map(persistenceManager::getUserByID)
+			.forEach(member -> persistenceManager.addContactBidirectional(member, group));
+		persistenceManager.addContactBidirectional(persistenceManager.getUserByID(connectionManager.getUserIDBySocketID(socketID)), group);
+		writeProxy.writeToOnlineContacts(group.getContacts(), new GroupCreationResult(group.toCommon()));
 	}
 }
diff --git a/server/src/main/java/envoy/server/processors/ContactOperationProcessor.java b/server/src/main/java/envoy/server/processors/UserOperationProcessor.java
similarity index 51%
rename from server/src/main/java/envoy/server/processors/ContactOperationProcessor.java
rename to server/src/main/java/envoy/server/processors/UserOperationProcessor.java
index 1fa74fb..b3d28be 100755
--- a/server/src/main/java/envoy/server/processors/ContactOperationProcessor.java
+++ b/server/src/main/java/envoy/server/processors/UserOperationProcessor.java
@@ -5,7 +5,7 @@ import java.util.logging.*;
 
 import envoy.event.ElementOperation;
 import envoy.event.contact.UserOperation;
-import envoy.server.data.*;
+import envoy.server.data.PersistenceManager;
 import envoy.server.net.*;
 import envoy.util.EnvoyLog;
 
@@ -13,10 +13,10 @@ import envoy.util.EnvoyLog;
  * @author Kai S. K. Engelbart
  * @since Envoy Server Standalone v0.1-alpha
  */
-public final class ContactOperationProcessor implements ObjectProcessor<UserOperation> {
+public final class UserOperationProcessor implements ObjectProcessor<UserOperation> {
 
 	private static final ConnectionManager	connectionManager	= ConnectionManager.getInstance();
-	private static final Logger				logger				= EnvoyLog.getLogger(ContactOperationProcessor.class);
+	private static final Logger				logger				= EnvoyLog.getLogger(UserOperationProcessor.class);
 	private static final PersistenceManager	persistenceManager	= PersistenceManager.getInstance();
 
 	@Override
@@ -38,35 +38,15 @@ public final class ContactOperationProcessor implements ObjectProcessor<UserOper
 				// Remove the relationships and notify sender if he logs in using another
 				// LocalDB
 				persistenceManager.removeContactBidirectional(userID, contactID);
-				final var contact = persistenceManager.getContactByID(contactID);
 				sender.setLatestContactDeletion(Instant.now());
 
-				// The sender wants to remove a normal contact
-				if (contact instanceof User) {
+				// Notify the removed contact on next startup(s) of this deletion
+				persistenceManager.getUserByID(contactID).setLatestContactDeletion(Instant.now());
 
-					// Notify the removed contact on next startup(s) of this deletion
-					persistenceManager.getUserByID(contactID).setLatestContactDeletion(Instant.now());
-
-					// Notify the removed contact if online
-					if (connectionManager.isOnline(contactID))
-						writeProxy.write(connectionManager.getSocketID(contactID), new UserOperation(sender.toCommon(), ElementOperation.REMOVE));
-				} else {
-
-					// The sender wants to be removed from a Group
-					final var group = persistenceManager.getGroupByID(contactID);
-
-					// The group has no more members and hence will be deleted
-					if (group.getContacts().isEmpty()) persistenceManager.deleteContact(group);
-					else {
-
-						// Informing the other members
-						writeProxy.writeToOnlineContacts(group.getContacts(), new UserOperation(sender.toCommon(), ElementOperation.REMOVE));
-						group.getContacts().forEach(c -> ((User) c).setLatestContactDeletion(Instant.now()));
-					}
-				}
+				// Notify the removed contact if online
+				if (connectionManager.isOnline(contactID))
+					writeProxy.write(connectionManager.getSocketID(contactID), new UserOperation(sender.toCommon(), ElementOperation.REMOVE));
 				break;
-			default:
-				logger.warning(String.format("Received %s with an unsupported operation.", evt));
 		}
 	}
 }
-- 
2.30.2


From c4d4708988e48cd634bcef750f759894e446251b Mon Sep 17 00:00:00 2001
From: delvh <leon@kske.dev>
Date: Fri, 16 Oct 2020 20:21:22 +0200
Subject: [PATCH 5/6] Add working leaving of a group

Additionally fixed a two bugs:
- one group member will no longer show "1 members"
- deletion of empty groups no longer throws an exception
---
 .../main/java/envoy/client/data/LocalDB.java  | 21 +++++++--
 .../client/ui/control/GroupSizeLabel.java     |  4 +-
 .../envoy/client/ui/controller/ChatScene.java | 14 ++++--
 .../main/java/envoy/client/util/UserUtil.java |  8 +++-
 .../src/main/java/envoy/server/Startup.java   |  1 +
 .../main/java/envoy/server/data/Message.java  |  2 +-
 .../envoy/server/data/PersistenceManager.java |  5 ---
 .../processors/GroupResizeProcessor.java      | 45 +++++++++++--------
 8 files changed, 66 insertions(+), 34 deletions(-)

diff --git a/client/src/main/java/envoy/client/data/LocalDB.java b/client/src/main/java/envoy/client/data/LocalDB.java
index 28b7ccd..7f93c18 100644
--- a/client/src/main/java/envoy/client/data/LocalDB.java
+++ b/client/src/main/java/envoy/client/data/LocalDB.java
@@ -379,12 +379,27 @@ public final class LocalDB implements EventListener {
 	 */
 	public void setUserAndMergeContacts(User user) {
 		this.user = user;
-		if (contactsChanged)
+		if (contactsChanged) {
+			final var contacts = user.getContacts();
 
 			// Mark chats as disabled if a contact is no longer in this users contact list
-			changedChats = chats.stream()
-				.filter(not(chat -> user.getContacts().contains(chat.getRecipient())))
+			final var changedUserChats = chats.stream()
+				.filter(not(chat -> contacts.contains(chat.getRecipient())))
 				.peek(chat -> { chat.setDisabled(true); logger.log(Level.INFO, String.format("Marked %s as blocked.", chat.getRecipient())); });
+
+			// Also update groups with a different member count
+			final var changedGroupChats = contacts.stream().filter(Group.class::isInstance).flatMap(group -> {
+				final var potentialChat = getChat(group.getID());
+				if (potentialChat.isEmpty()) return Stream.empty();
+				final var chat = potentialChat.get();
+				if (group.getContacts().size() != chat.getRecipient().getContacts().size()) {
+					logger.log(Level.INFO, "Removed one (or more) members from " + group);
+					return Stream.of(chat);
+				} else return Stream.empty();
+			});
+
+			changedChats = Stream.concat(changedUserChats, changedGroupChats);
+		}
 	}
 
 	/**
diff --git a/client/src/main/java/envoy/client/ui/control/GroupSizeLabel.java b/client/src/main/java/envoy/client/ui/control/GroupSizeLabel.java
index 8413744..120206d 100644
--- a/client/src/main/java/envoy/client/ui/control/GroupSizeLabel.java
+++ b/client/src/main/java/envoy/client/ui/control/GroupSizeLabel.java
@@ -16,5 +16,7 @@ public final class GroupSizeLabel extends Label {
 	 * @param recipient the group whose members to show
 	 * @since Envoy Client v0.3-beta
 	 */
-	public GroupSizeLabel(Group recipient) { super(recipient.getContacts().size() + " members"); }
+	public GroupSizeLabel(Group recipient) {
+		super(recipient.getContacts().size() + " member" + (recipient.getContacts().size() != 1 ? "s" : ""));
+	}
 }
diff --git a/client/src/main/java/envoy/client/ui/controller/ChatScene.java b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
index b28e428..fa072b6 100644
--- a/client/src/main/java/envoy/client/ui/controller/ChatScene.java
+++ b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
@@ -281,7 +281,8 @@ public final class ChatScene implements EventListener, Restorable {
 
 			// Update the top-bar status label if all conditions apply
 			if (currentChat != null && currentChat.getRecipient().equals(chatFound.get().getRecipient()))
-				topBarStatusLabel.setText(chatFound.get().getRecipient().getContacts().size() + " members");
+				topBarStatusLabel.setText(chatFound.get().getRecipient().getContacts().size() + " member"
+						+ (currentChat.getRecipient().getContacts().size() != 1 ? "s" : ""));
 		});
 	}
 
@@ -383,7 +384,8 @@ public final class ChatScene implements EventListener, Restorable {
 				topBarStatusLabel.setVisible(true);
 				recipientProfilePic.setImage(IconUtil.loadIconThemeSensitive("user_icon", 43));
 			} else {
-				topBarStatusLabel.setText(currentChat.getRecipient().getContacts().size() + " members");
+				topBarStatusLabel.setText(currentChat.getRecipient().getContacts().size() + " member"
+						+ (currentChat.getRecipient().getContacts().size() != 1 ? "s" : ""));
 				topBarStatusLabel.getStyleClass().clear();
 				recipientProfilePic.setImage(IconUtil.loadIconThemeSensitive("group_icon", 43));
 			}
@@ -752,7 +754,13 @@ public final class ChatScene implements EventListener, Restorable {
 	 * @since Envoy Client v0.3-beta
 	 */
 	public void disableChat(Contact recipient, boolean refreshChatList) {
-		if (refreshChatList) chatList.refresh();
+		if (refreshChatList) {
+			chatList.refresh();
+
+			// Decrement member count for groups
+			if (recipient instanceof Group)
+				topBarStatusLabel.setText(recipient.getContacts().size() + " member" + (recipient.getContacts().size() != 1 ? "s" : ""));
+		}
 		if (currentChat != null && currentChat.getRecipient().equals(recipient)) {
 			messageTextArea.setDisable(true);
 			voiceButton.setDisable(true);
diff --git a/client/src/main/java/envoy/client/util/UserUtil.java b/client/src/main/java/envoy/client/util/UserUtil.java
index c6477b1..404dd23 100644
--- a/client/src/main/java/envoy/client/util/UserUtil.java
+++ b/client/src/main/java/envoy/client/util/UserUtil.java
@@ -82,15 +82,19 @@ public final class UserUtil {
 		if (!context.getClient().isOnline() || block == null) return;
 		else {
 			final var alert = new Alert(AlertType.CONFIRMATION);
-			alert.setContentText("Are you sure you want to block " + block.getName() + "?");
+			alert.setContentText("Are you sure you want to " + (block instanceof User ? "block " : "leave group ") + block.getName() + "?");
 			AlertHelper.confirmAction(alert, () -> {
 				context.getClient()
 					.send(block instanceof User ? new UserOperation((User) block, ElementOperation.REMOVE)
 							: new GroupResize(context.getLocalDB().getUser(), (Group) block, ElementOperation.REMOVE));
 				context.getLocalDB().getChat(block.getID()).ifPresent(chat -> chat.setDisabled(true));
+				if (block instanceof User) logger.log(Level.INFO, "A user was blocked.");
+				else {
+					block.getContacts().remove(context.getLocalDB().getUser());
+					logger.log(Level.INFO, "The user left a group.");
+				}
 				final var controller = context.getSceneContext().getController();
 				if (controller instanceof ChatScene) ((ChatScene) controller).disableChat(block, true);
-				logger.log(Level.INFO, "A contact was blocked.");
 			});
 		}
 	}
diff --git a/server/src/main/java/envoy/server/Startup.java b/server/src/main/java/envoy/server/Startup.java
index db890ac..13065ba 100755
--- a/server/src/main/java/envoy/server/Startup.java
+++ b/server/src/main/java/envoy/server/Startup.java
@@ -49,6 +49,7 @@ public final class Startup {
 						new MessageStatusChangeProcessor(),
 						new GroupMessageStatusChangeProcessor(),
 						new UserStatusChangeProcessor(),
+						new GroupResizeProcessor(),
 						new IDGeneratorRequestProcessor(),
 						new UserSearchProcessor(),
 						new UserOperationProcessor(),
diff --git a/server/src/main/java/envoy/server/data/Message.java b/server/src/main/java/envoy/server/data/Message.java
index b4c5fe1..4b9cb12 100755
--- a/server/src/main/java/envoy/server/data/Message.java
+++ b/server/src/main/java/envoy/server/data/Message.java
@@ -51,7 +51,7 @@ public class Message {
 	@Id
 	protected long id;
 
-	@ManyToOne
+	@ManyToOne(cascade = CascadeType.REMOVE)
 	@JoinColumn
 	protected User sender;
 
diff --git a/server/src/main/java/envoy/server/data/PersistenceManager.java b/server/src/main/java/envoy/server/data/PersistenceManager.java
index 2c9bf33..e7acc61 100755
--- a/server/src/main/java/envoy/server/data/PersistenceManager.java
+++ b/server/src/main/java/envoy/server/data/PersistenceManager.java
@@ -105,11 +105,6 @@ public final class PersistenceManager {
 			// Remove this contact from the contact list of his contacts
 			for (final var remainingContact : contact.getContacts())
 				remainingContact.getContacts().remove(contact);
-
-			// Delete messages sent or received by this contact
-			entityManager.createQuery("DELETE FROM Message m WHERE (m.sender = :contact OR m.recipient = :contact )")
-				.setParameter("contact", contact)
-				.executeUpdate();
 		});
 		remove(contact);
 	}
diff --git a/server/src/main/java/envoy/server/processors/GroupResizeProcessor.java b/server/src/main/java/envoy/server/processors/GroupResizeProcessor.java
index 0a5b697..b0cacd9 100644
--- a/server/src/main/java/envoy/server/processors/GroupResizeProcessor.java
+++ b/server/src/main/java/envoy/server/processors/GroupResizeProcessor.java
@@ -1,8 +1,12 @@
 package envoy.server.processors;
 
+import java.time.Instant;
+import java.util.logging.Level;
+
 import envoy.event.GroupResize;
 import envoy.server.data.*;
-import envoy.server.net.*;
+import envoy.server.net.ObjectWriteProxy;
+import envoy.util.EnvoyLog;
 
 /**
  * @author Maximilian K&auml;fer
@@ -10,35 +14,38 @@ import envoy.server.net.*;
  */
 public final class GroupResizeProcessor implements ObjectProcessor<GroupResize> {
 
-	private static final PersistenceManager	persistenceManager	= PersistenceManager.getInstance();
-	private static final ConnectionManager	connectionManager	= ConnectionManager.getInstance();
+	private static final PersistenceManager persistenceManager = PersistenceManager.getInstance();
 
 	@Override
 	public void process(GroupResize groupResize, long socketID, ObjectWriteProxy writeProxy) {
 
 		// Acquire the group to resize from the database
-		var group = persistenceManager.getGroupByID(groupResize.getGroupID());
+		final var	group	= persistenceManager.getGroupByID(groupResize.getGroupID());
+		final var	sender	= persistenceManager.getUserByID(groupResize.get().getID());
 
 		// Perform the desired operation
 		switch (groupResize.getOperation()) {
 			case ADD:
-				group.getContacts().add(persistenceManager.getUserByID(groupResize.get().getID()));
-				break;
+				persistenceManager.addContactBidirectional(sender, group);
+				writeProxy.writeToOnlineContacts(group.getContacts(), group.toCommon());
+				return;
 			case REMOVE:
+				persistenceManager.removeContactBidirectional(sender, group);
+				sender.setLatestContactDeletion(Instant.now());
+
+				// The group has no more members and hence will be deleted
+				if (group.getContacts().isEmpty()) {
+					EnvoyLog.getLogger(GroupResizeProcessor.class).log(Level.INFO, "Deleting now empty group " + group.getName());
+					persistenceManager.deleteContact(group);
+				} else {
+
+					// Informing the other members
+					writeProxy.writeToOnlineContacts(group.getContacts(), groupResize);
+					group.getContacts().forEach(c -> ((User) c).setLatestContactDeletion(Instant.now()));
+				}
+
 				group.getContacts().remove(persistenceManager.getUserByID(groupResize.get().getID()));
-				break;
+				return;
 		}
-
-		// Update the group in the database
-		persistenceManager.updateContact(group);
-
-		// Send the updated group to all of its members
-		var commonGroup = group.toCommon();
-		group.getContacts()
-			.stream()
-			.map(Contact::getID)
-			.filter(connectionManager::isOnline)
-			.map(connectionManager::getSocketID)
-			.forEach(memberSocketID -> writeProxy.write(memberSocketID, commonGroup));
 	}
 }
-- 
2.30.2


From 5aaad61347e96378fe95d67e5721b963af6c9059 Mon Sep 17 00:00:00 2001
From: delvh <leon@kske.dev>
Date: Sat, 17 Oct 2020 16:40:13 +0200
Subject: [PATCH 6/6] Apply suggestions by @kske

Additionally fixed three bugs/ inconsistencies:
- status changing keyboard shortcuts are present again
- deleted cells no longer show a hand cursor
- any event method in LocalDB needing higher priority now has priority
500
---
 .../src/main/java/envoy/client/data/Chat.java | 35 +++++---
 .../main/java/envoy/client/data/LocalDB.java  | 87 ++++++++-----------
 .../main/java/envoy/client/data/Settings.java |  2 +-
 .../data/shortcuts/EnvoyShortcutConfig.java   | 21 +++++
 .../envoy/client/event/ContactDisabled.java   | 21 +++++
 .../main/java/envoy/client/net/Client.java    | 29 ++-----
 .../main/java/envoy/client/ui/Startup.java    |  2 +-
 .../envoy/client/ui/control/ChatControl.java  | 35 +++-----
 .../envoy/client/ui/controller/ChatScene.java | 48 ++++------
 .../client/ui/listcell/AbstractListCell.java  |  1 +
 .../client/ui/listcell/ChatListCell.java      | 46 ++++++++++
 .../main/java/envoy/client/util/UserUtil.java | 23 ++---
 client/src/main/resources/css/base.css        |  2 +-
 .../java/envoy/util/SerializationUtils.java   |  8 +-
 14 files changed, 193 insertions(+), 167 deletions(-)
 create mode 100644 client/src/main/java/envoy/client/event/ContactDisabled.java
 create mode 100644 client/src/main/java/envoy/client/ui/listcell/ChatListCell.java

diff --git a/client/src/main/java/envoy/client/data/Chat.java b/client/src/main/java/envoy/client/data/Chat.java
index d8b2ee8..6b0bd83 100644
--- a/client/src/main/java/envoy/client/data/Chat.java
+++ b/client/src/main/java/envoy/client/data/Chat.java
@@ -21,13 +21,12 @@ import envoy.event.MessageStatusChange;
  */
 public class Chat implements Serializable {
 
-	protected final Contact recipient;
-
 	protected transient ObservableList<Message> messages = FXCollections.observableArrayList();
 
-	protected int unreadAmount;
+	protected int		unreadAmount;
+	protected boolean	disabled;
 
-	private boolean disabled;
+	protected final Contact recipient;
 
 	/**
 	 * Stores the last time an {@link envoy.event.IsTyping} event has been sent.
@@ -58,7 +57,13 @@ public class Chat implements Serializable {
 
 	@Override
 	public String toString() {
-		return String.format("%s[recipient=%s,messages=%d, disabled=%b]", getClass().getSimpleName(), recipient, messages.size(), disabled);
+		return String.format(
+			"%s[recipient=%s,messages=%d,disabled=%b]",
+			getClass().getSimpleName(),
+			recipient,
+			messages.size(),
+			disabled
+		);
 	}
 
 	/**
@@ -94,11 +99,13 @@ public class Chat implements Serializable {
 	public void read(WriteProxy writeProxy) {
 		for (int i = messages.size() - 1; i >= 0; --i) {
 			final var m = messages.get(i);
-			if (m.getSenderID() == recipient.getID()) if (m.getStatus() == MessageStatus.READ) break;
-			else {
-				m.setStatus(MessageStatus.READ);
-				writeProxy.writeMessageStatusChange(new MessageStatusChange(m));
-			}
+			if (m.getSenderID() == recipient.getID())
+				if (m.getStatus() == MessageStatus.READ)
+					break;
+				else {
+					m.setStatus(MessageStatus.READ);
+					writeProxy.writeMessageStatusChange(new MessageStatusChange(m));
+				}
 		}
 		unreadAmount = 0;
 	}
@@ -174,10 +181,10 @@ public class Chat implements Serializable {
 	public void lastWritingEventWasNow() { lastWritingEvent = System.currentTimeMillis(); }
 
 	/**
-	 * Determines whether messages can be sent in this chat. Should be true i.e. for
-	 * chats whose recipient deleted this client as a contact.
+	 * Determines whether messages can be sent in this chat. Should be {@code true}
+	 * i.e. for chats whose recipient deleted this client as a contact.
 	 *
-	 * @return whether this {@code Chat} has been disabled
+	 * @return whether this chat has been disabled
 	 * @since Envoy Client v0.3-beta
 	 */
 	public boolean isDisabled() { return disabled; }
@@ -186,7 +193,7 @@ public class Chat implements Serializable {
 	 * Determines whether messages can be sent in this chat. Should be true i.e. for
 	 * chats whose recipient deleted this client as a contact.
 	 *
-	 * @param disabled the disabled to set
+	 * @param disabled whether this chat should be disabled
 	 * @since Envoy Client v0.3-beta
 	 */
 	public void setDisabled(boolean disabled) { this.disabled = disabled; }
diff --git a/client/src/main/java/envoy/client/data/LocalDB.java b/client/src/main/java/envoy/client/data/LocalDB.java
index 7f93c18..a18c3e9 100644
--- a/client/src/main/java/envoy/client/data/LocalDB.java
+++ b/client/src/main/java/envoy/client/data/LocalDB.java
@@ -44,7 +44,6 @@ public final class LocalDB implements EventListener {
 	private CacheMap				cacheMap	= new CacheMap();
 	private String					authToken;
 	private boolean					contactsChanged;
-	private Stream<Chat>			changedChats;
 
 	// Auto save timer
 	private Timer	autoSaver;
@@ -144,16 +143,29 @@ public final class LocalDB implements EventListener {
 		try (var in = new ObjectInputStream(new FileInputStream(userFile))) {
 			chats = FXCollections.observableList((List<Chat>) in.readObject());
 
-			// Some chats have changed and should not be overridden by the saved values
-			if (changedChats != null) {
-				changedChats.forEach(chat -> {
-					final var chatIndex = chats.indexOf(chat);
-					if (chatIndex == -1) return;
-					else chats.set(chatIndex, chat);
+			// Some chats have changed and should not be overwritten by the saved values
+			if (contactsChanged) {
+				final var contacts = user.getContacts();
+
+				// Mark chats as disabled if a contact is no longer in this users contact list
+				final var changedUserChats = chats.stream()
+					.filter(not(chat -> contacts.contains(chat.getRecipient())))
+					.peek(chat -> { chat.setDisabled(true); logger.log(Level.INFO, String.format("Deleted chat with %s.", chat.getRecipient())); });
+
+				// Also update groups with a different member count
+				final var changedGroupChats = contacts.stream().filter(Group.class::isInstance).flatMap(group -> {
+					final var potentialChat = getChat(group.getID());
+					if (potentialChat.isEmpty()) return Stream.empty();
+					final var chat = potentialChat.get();
+					if (group.getContacts().size() != chat.getRecipient().getContacts().size()) {
+						logger.log(Level.INFO, "Removed one (or more) members from " + group);
+						return Stream.of(chat);
+					} else return Stream.empty();
 				});
+				Stream.concat(changedUserChats, changedGroupChats).forEach(chat -> chats.set(chats.indexOf(chat), chat));
 
 				// loadUserData can get called two (or more?) times during application lifecycle
-				changedChats = null;
+				contactsChanged = false;
 			}
 			cacheMap	= (CacheMap) in.readObject();
 			lastSync	= (Instant) in.readObject();
@@ -213,7 +225,7 @@ public final class LocalDB implements EventListener {
 	 * @throws IOException if the saving process failed
 	 * @since Envoy Client v0.3-alpha
 	 */
-	@Event(eventType = EnvoyCloseEvent.class, priority = 1000)
+	@Event(eventType = EnvoyCloseEvent.class, priority = 500)
 	private synchronized void save() {
 		EnvoyLog.getLogger(LocalDB.class).log(Level.FINER, "Saving local database...");
 
@@ -235,35 +247,34 @@ public final class LocalDB implements EventListener {
 		}
 	}
 
-	@Event(priority = 150)
+	@Event(priority = 500)
 	private void onMessage(Message msg) { if (msg.getStatus() == MessageStatus.SENT) msg.nextStatus(); }
 
-	@Event(priority = 150)
+	@Event(priority = 500)
 	private void onGroupMessage(GroupMessage msg) {
 		// TODO: Cancel event once EventBus is updated
 		if (msg.getStatus() == MessageStatus.WAITING || msg.getStatus() == MessageStatus.READ)
 			logger.warning("The groupMessage has the unexpected status " + msg.getStatus());
 	}
 
-	@Event(priority = 150)
+	@Event(priority = 500)
 	private void onMessageStatusChange(MessageStatusChange evt) { getMessage(evt.getID()).ifPresent(msg -> msg.setStatus(evt.get())); }
 
-	@Event(priority = 150)
+	@Event(priority = 500)
 	private void onGroupMessageStatusChange(GroupMessageStatusChange evt) {
 		this.<GroupMessage>getMessage(evt.getID()).ifPresent(msg -> msg.getMemberStatuses().replace(evt.getMemberID(), evt.get()));
 	}
 
-	@Event(priority = 150)
+	@Event(priority = 500)
 	private void onUserStatusChange(UserStatusChange evt) {
 		getChat(evt.getID()).map(Chat::getRecipient).map(User.class::cast).ifPresent(u -> u.setStatus(evt.get()));
 	}
 
-	@Event(priority = 200)
+	@Event(priority = 500)
 	private void onUserOperation(UserOperation operation) {
 		final var eventUser = operation.get();
 		switch (operation.getOperationType()) {
 			case ADD:
-				getUsers().put(eventUser.getName(), eventUser);
 				Platform.runLater(() -> chats.add(0, new Chat(eventUser)));
 				break;
 			case REMOVE:
@@ -283,10 +294,10 @@ public final class LocalDB implements EventListener {
 		else Platform.runLater(() -> chats.add(new GroupChat(user, newGroup)));
 	}
 
-	@Event(priority = 150)
+	@Event(priority = 500)
 	private void onGroupResize(GroupResize evt) { getChat(evt.getGroupID()).map(Chat::getRecipient).map(Group.class::cast).ifPresent(evt::apply); }
 
-	@Event(priority = 150)
+	@Event(priority = 500)
 	private void onNameChange(NameChange evt) {
 		chats.stream().map(Chat::getRecipient).filter(c -> c.getID() == evt.getID()).findAny().ifPresent(c -> c.setName(evt.get()));
 	}
@@ -305,7 +316,7 @@ public final class LocalDB implements EventListener {
 	 *
 	 * @since Envoy Client v0.2-beta
 	 */
-	@Event(eventType = Logout.class, priority = 100)
+	@Event(eventType = Logout.class, priority = 50)
 	private void onLogout() {
 		autoSaver.cancel();
 		autoSaveRestart = true;
@@ -340,7 +351,10 @@ public final class LocalDB implements EventListener {
 	private void onOwnStatusChange(OwnStatusChange statusChange) { user.setStatus(statusChange.get()); }
 
 	@Event(eventType = ContactsChangedSinceLastLogin.class, priority = 500)
-	private void onContactsChangedSinceLastLogin() { if (user != null) contactsChanged = true; }
+	private void onContactsChangedSinceLastLogin() { contactsChanged = true; }
+
+	@Event(priority = 500)
+	private void onContactDisabled(ContactDisabled event) { getChat(event.get().getID()).ifPresent(chat -> chat.setDisabled(true)); }
 
 	/**
 	 * @return a {@code Map<String, User>} of all users stored locally with their
@@ -369,39 +383,6 @@ public final class LocalDB implements EventListener {
 	 */
 	public Optional<Chat> getChat(long recipientID) { return chats.stream().filter(c -> c.getRecipient().getID() == recipientID).findAny(); }
 
-	/**
-	 * Sets the given user as base of this {@code LocalDB}.
-	 * Additionally compares his contacts with the ones returned by the server, in
-	 * case they might have been deleted.
-	 *
-	 * @param user the user to set
-	 * @since Envoy Client v0.2-alpha
-	 */
-	public void setUserAndMergeContacts(User user) {
-		this.user = user;
-		if (contactsChanged) {
-			final var contacts = user.getContacts();
-
-			// Mark chats as disabled if a contact is no longer in this users contact list
-			final var changedUserChats = chats.stream()
-				.filter(not(chat -> contacts.contains(chat.getRecipient())))
-				.peek(chat -> { chat.setDisabled(true); logger.log(Level.INFO, String.format("Marked %s as blocked.", chat.getRecipient())); });
-
-			// Also update groups with a different member count
-			final var changedGroupChats = contacts.stream().filter(Group.class::isInstance).flatMap(group -> {
-				final var potentialChat = getChat(group.getID());
-				if (potentialChat.isEmpty()) return Stream.empty();
-				final var chat = potentialChat.get();
-				if (group.getContacts().size() != chat.getRecipient().getContacts().size()) {
-					logger.log(Level.INFO, "Removed one (or more) members from " + group);
-					return Stream.of(chat);
-				} else return Stream.empty();
-			});
-
-			changedChats = Stream.concat(changedUserChats, changedGroupChats);
-		}
-	}
-
 	/**
 	 * @return all saved {@link Chat} objects that list the client user as the
 	 *         sender
diff --git a/client/src/main/java/envoy/client/data/Settings.java b/client/src/main/java/envoy/client/data/Settings.java
index 9b317cd..8f56774 100644
--- a/client/src/main/java/envoy/client/data/Settings.java
+++ b/client/src/main/java/envoy/client/data/Settings.java
@@ -68,7 +68,7 @@ public final class Settings implements EventListener {
 	 * @throws IOException if an error occurs while saving the themes
 	 * @since Envoy Client v0.2-alpha
 	 */
-	@Event(eventType = EnvoyCloseEvent.class, priority = 900)
+	@Event(eventType = EnvoyCloseEvent.class)
 	private void save() {
 		EnvoyLog.getLogger(Settings.class).log(Level.INFO, "Saving settings...");
 
diff --git a/client/src/main/java/envoy/client/data/shortcuts/EnvoyShortcutConfig.java b/client/src/main/java/envoy/client/data/shortcuts/EnvoyShortcutConfig.java
index 14a110c..0f58e97 100644
--- a/client/src/main/java/envoy/client/data/shortcuts/EnvoyShortcutConfig.java
+++ b/client/src/main/java/envoy/client/data/shortcuts/EnvoyShortcutConfig.java
@@ -6,6 +6,7 @@ import envoy.client.data.Context;
 import envoy.client.helper.ShutdownHelper;
 import envoy.client.ui.SceneContext.SceneInfo;
 import envoy.client.util.UserUtil;
+import envoy.data.User.UserStatus;
 
 /**
  * Envoy-specific implementation of the keyboard-shortcut interaction offered by
@@ -40,5 +41,25 @@ public class EnvoyShortcutConfig {
 				() -> Context.getInstance().getSceneContext().load(SceneInfo.SETTINGS_SCENE),
 				SceneInfo.SETTINGS_SCENE,
 				SceneInfo.LOGIN_SCENE);
+
+		// Add option to change to status away
+		instance.addForNotExcluded(new KeyCodeCombination(KeyCode.A, KeyCombination.CONTROL_DOWN, KeyCombination.SHIFT_DOWN),
+				() -> UserUtil.changeStatus(UserStatus.AWAY),
+				SceneInfo.LOGIN_SCENE);
+
+		// Add option to change to status busy
+		instance.addForNotExcluded(new KeyCodeCombination(KeyCode.B, KeyCombination.CONTROL_DOWN, KeyCombination.SHIFT_DOWN),
+				() -> UserUtil.changeStatus(UserStatus.BUSY),
+				SceneInfo.LOGIN_SCENE);
+
+		// Add option to change to status offline
+		instance.addForNotExcluded(new KeyCodeCombination(KeyCode.F, KeyCombination.CONTROL_DOWN, KeyCombination.SHIFT_DOWN),
+				() -> UserUtil.changeStatus(UserStatus.OFFLINE),
+				SceneInfo.LOGIN_SCENE);
+
+		// Add option to change to status online
+		instance.addForNotExcluded(new KeyCodeCombination(KeyCode.N, KeyCombination.CONTROL_DOWN, KeyCombination.SHIFT_DOWN),
+				() -> UserUtil.changeStatus(UserStatus.ONLINE),
+				SceneInfo.LOGIN_SCENE);
 	}
 }
diff --git a/client/src/main/java/envoy/client/event/ContactDisabled.java b/client/src/main/java/envoy/client/event/ContactDisabled.java
new file mode 100644
index 0000000..c3721fe
--- /dev/null
+++ b/client/src/main/java/envoy/client/event/ContactDisabled.java
@@ -0,0 +1,21 @@
+package envoy.client.event;
+
+import envoy.data.Contact;
+import envoy.event.Event;
+
+/**
+ * Signifies that the chat of a contact should be disabled.
+ *
+ * @author Leon Hofmeister
+ * @since Envoy Client v0.3-beta
+ */
+public class ContactDisabled extends Event<Contact> {
+
+	private static final long serialVersionUID = 1L;
+
+	/**
+	 * @param contact the contact that should be disabled
+	 * @since Envoy Client v0.3-beta
+	 */
+	public ContactDisabled(Contact contact) { super(contact); }
+}
diff --git a/client/src/main/java/envoy/client/net/Client.java b/client/src/main/java/envoy/client/net/Client.java
index e84388d..3b886eb 100644
--- a/client/src/main/java/envoy/client/net/Client.java
+++ b/client/src/main/java/envoy/client/net/Client.java
@@ -9,7 +9,6 @@ import envoy.client.data.*;
 import envoy.client.event.EnvoyCloseEvent;
 import envoy.data.*;
 import envoy.event.*;
-import envoy.event.contact.ContactsChangedSinceLastLogin;
 import envoy.util.*;
 
 import dev.kske.eventbus.*;
@@ -30,7 +29,6 @@ public final class Client implements EventListener, Closeable {
 	private Socket		socket;
 	private Receiver	receiver;
 	private boolean		online;
-	private boolean		isHandShake;
 
 	// Asynchronously initialized during handshake
 	private volatile User		sender;
@@ -63,7 +61,7 @@ public final class Client implements EventListener, Closeable {
 	 */
 	public void performHandshake(LoginCredentials credentials, CacheMap cacheMap) throws TimeoutException, IOException, InterruptedException {
 		if (online) throw new IllegalStateException("Handshake has already been performed successfully");
-		isHandShake = true;
+		rejected = false;
 
 		// Establish TCP connection
 		logger.log(Level.FINER, String.format("Attempting connection to server %s:%d...", config.getServer(), config.getPort()));
@@ -78,8 +76,6 @@ public final class Client implements EventListener, Closeable {
 		receiver.registerProcessor(User.class, sender -> this.sender = sender);
 		receiver.registerProcessors(cacheMap.getMap());
 
-		rejected = false;
-
 		// Start receiver
 		receiver.start();
 
@@ -95,19 +91,17 @@ public final class Client implements EventListener, Closeable {
 			if (rejected) {
 				socket.close();
 				receiver.removeAllProcessors();
-				isHandShake = false;
 				return;
 			}
 
 			if (System.currentTimeMillis() - start > 5000) {
-				isHandShake = false;
+				rejected = true;
 				throw new TimeoutException("Did not log in after 5 seconds");
 			}
 			Thread.sleep(500);
 		}
 
-		online		= true;
-		isHandShake	= false;
+		online = true;
 		logger.log(Level.INFO, "Handshake completed.");
 	}
 
@@ -182,23 +176,10 @@ public final class Client implements EventListener, Closeable {
 	}
 
 	@Event(eventType = HandshakeRejection.class, priority = 1000)
-	private void onHandshakeRejection() {
-		rejected	= true;
-		isHandShake	= false;
-	}
-
-	@Event(eventType = ContactsChangedSinceLastLogin.class, priority = 1000)
-	private void onContactsChangedSinceLastLogin() {
-		if (!isHandShake) {
-			logger.log(Level.WARNING, "Received a request to check contacts while not in the handshake");
-
-			// TODO: consume event once event consumption is implemented
-			return;
-		}
-	}
+	private void onHandshakeRejection() { rejected = true; }
 
 	@Override
-	@Event(eventType = EnvoyCloseEvent.class, priority = 800)
+	@Event(eventType = EnvoyCloseEvent.class, priority = 50)
 	public void close() {
 		if (online) {
 			logger.log(Level.INFO, "Closing connection...");
diff --git a/client/src/main/java/envoy/client/ui/Startup.java b/client/src/main/java/envoy/client/ui/Startup.java
index cd4ddbc..a93bf81 100644
--- a/client/src/main/java/envoy/client/ui/Startup.java
+++ b/client/src/main/java/envoy/client/ui/Startup.java
@@ -179,7 +179,7 @@ public final class Startup extends Application {
 
 		// Set client user in local database
 		final var user = client.getSender();
-		localDB.setUserAndMergeContacts(user);
+		localDB.setUser(user);
 
 		// Initialize chats in local database
 		try {
diff --git a/client/src/main/java/envoy/client/ui/control/ChatControl.java b/client/src/main/java/envoy/client/ui/control/ChatControl.java
index c42ec28..353bdaf 100644
--- a/client/src/main/java/envoy/client/ui/control/ChatControl.java
+++ b/client/src/main/java/envoy/client/ui/control/ChatControl.java
@@ -1,13 +1,12 @@
 package envoy.client.ui.control;
 
 import javafx.geometry.*;
-import javafx.scene.control.*;
+import javafx.scene.control.Label;
 import javafx.scene.image.Image;
 import javafx.scene.layout.*;
 
 import envoy.client.data.*;
-import envoy.client.util.*;
-import envoy.data.User;
+import envoy.client.util.IconUtil;
 
 /**
  * Displays a chat using a contact control for the recipient and a label for the
@@ -17,7 +16,7 @@ import envoy.data.User;
  * @author Leon Hofmeister
  * @since Envoy Client v0.1-beta
  */
-public final class ChatControl extends Label {
+public final class ChatControl extends HBox {
 
 	private static final Image userIcon = IconUtil.loadIconThemeSensitive("user_icon", 32),
 			groupIcon = IconUtil.loadIconThemeSensitive("group_icon", 32);
@@ -32,35 +31,25 @@ public final class ChatControl extends Label {
 		setAlignment(Pos.CENTER_LEFT);
 		setPadding(new Insets(0, 0, 3, 0));
 
-		final var	menu		= new ContextMenu();
-		final var	removeMI	= new MenuItem();
-		removeMI
-			.setText(chat.isDisabled() ? "Delete " : chat.getRecipient() instanceof User ? "Block " : "Leave group " + chat.getRecipient().getName());
-		removeMI.setOnAction(chat.isDisabled() ? e -> UserUtil.deleteContact(chat.getRecipient()) : e -> UserUtil.blockContact(chat.getRecipient()));
-		menu.getItems().add(removeMI);
-		setContextMenu(menu);
-
-		final var display = new HBox();
-
 		// Profile picture
 		final var contactProfilePic = new ProfilePicImageView(chat instanceof GroupChat ? groupIcon : userIcon, 32);
-		display.getChildren().add(contactProfilePic);
+		getChildren().add(contactProfilePic);
 
 		// Spacing
 		final var leftSpacing = new Region();
 		leftSpacing.setPrefSize(8, 0);
 		leftSpacing.setMinSize(8, 0);
 		leftSpacing.setMaxSize(8, 0);
-		display.getChildren().add(leftSpacing);
+		getChildren().add(leftSpacing);
 
 		// Contact control
-		display.getChildren().add(new ContactControl(chat.getRecipient()));
+		getChildren().add(new ContactControl(chat.getRecipient()));
 
 		// Unread messages
 		if (chat.getUnreadAmount() != 0) {
 			final var spacing = new Region();
-			HBox.setHgrow(spacing, Priority.ALWAYS);
-			display.getChildren().add(spacing);
+			setHgrow(spacing, Priority.ALWAYS);
+			getChildren().add(spacing);
 			final var unreadMessagesLabel = new Label(Integer.toString(chat.getUnreadAmount()));
 			unreadMessagesLabel.setMinSize(15, 15);
 			final var vbox = new VBox();
@@ -68,12 +57,8 @@ public final class ChatControl extends Label {
 			unreadMessagesLabel.setAlignment(Pos.CENTER);
 			unreadMessagesLabel.getStyleClass().add("unread-messages-amount");
 			vbox.getChildren().add(unreadMessagesLabel);
-			display.getChildren().add(vbox);
+			getChildren().add(vbox);
 		}
-
-		setGraphic(display);
-
-		// Set background depending on whether it is disabled or not
-		getStyleClass().add(chat.isDisabled() ? "disabled-chat" : "list-element");
+		getStyleClass().add("list-element");
 	}
 }
diff --git a/client/src/main/java/envoy/client/ui/controller/ChatScene.java b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
index fa072b6..e472380 100644
--- a/client/src/main/java/envoy/client/ui/controller/ChatScene.java
+++ b/client/src/main/java/envoy/client/ui/controller/ChatScene.java
@@ -162,7 +162,7 @@ public final class ChatScene implements EventListener, Restorable {
 
 		// Initialize message and user rendering
 		messageList.setCellFactory(MessageListCell::new);
-		chatList.setCellFactory(new ListCellFactory<>(ChatControl::new));
+		chatList.setCellFactory(ChatListCell::new);
 
 		// JavaFX provides an internal way of populating the context menu of a text
 		// area.
@@ -268,22 +268,21 @@ public final class ChatScene implements EventListener, Restorable {
 
 	@Event
 	private void onUserOperation(UserOperation operation) {
-		// All ADD dependant logic resides in LocalDB
-		if (operation.getOperationType().equals(ElementOperation.REMOVE)) Platform.runLater(() -> disableChat(operation.get(), true));
+
+		// All ADD dependent logic resides in LocalDB
+		if (operation.getOperationType().equals(ElementOperation.REMOVE)) Platform.runLater(() -> disableChat(new ContactDisabled(operation.get())));
 	}
 
 	@Event
 	private void onGroupResize(GroupResize resize) {
 		final var chatFound = localDB.getChat(resize.getGroupID());
-		if (chatFound.isEmpty()) return;
-		Platform.runLater(() -> {
+		chatFound.ifPresent(chat -> Platform.runLater(() -> {
 			chatList.refresh();
 
 			// Update the top-bar status label if all conditions apply
-			if (currentChat != null && currentChat.getRecipient().equals(chatFound.get().getRecipient()))
-				topBarStatusLabel.setText(chatFound.get().getRecipient().getContacts().size() + " member"
-						+ (currentChat.getRecipient().getContacts().size() != 1 ? "s" : ""));
-		});
+			if (currentChat != null && currentChat.getRecipient().equals(chat.getRecipient())) topBarStatusLabel
+				.setText(chat.getRecipient().getContacts().size() + " member" + (currentChat.getRecipient().getContacts().size() != 1 ? "s" : ""));
+		}));
 	}
 
 	@Event(eventType = NoAttachments.class)
@@ -331,7 +330,7 @@ public final class ChatScene implements EventListener, Restorable {
 	 */
 	@FXML
 	private void chatListClicked() {
-		if (currentChat != null && chatList.getSelectionModel().isEmpty()) return;
+		if (chatList.getSelectionModel().isEmpty()) return;
 		final var chat = chatList.getSelectionModel().getSelectedItem();
 		if (chat == null) return;
 
@@ -376,12 +375,12 @@ public final class ChatScene implements EventListener, Restorable {
 		if (currentChat != null) {
 			topBarContactLabel.setText(currentChat.getRecipient().getName());
 			topBarContactLabel.setVisible(true);
+			topBarStatusLabel.setVisible(true);
 			if (currentChat.getRecipient() instanceof User) {
 				final var status = ((User) currentChat.getRecipient()).getStatus().toString();
 				topBarStatusLabel.setText(status);
 				topBarStatusLabel.getStyleClass().clear();
 				topBarStatusLabel.getStyleClass().add(status.toLowerCase());
-				topBarStatusLabel.setVisible(true);
 				recipientProfilePic.setImage(IconUtil.loadIconThemeSensitive("user_icon", 43));
 			} else {
 				topBarStatusLabel.setText(currentChat.getRecipient().getContacts().size() + " member"
@@ -395,11 +394,7 @@ public final class ChatScene implements EventListener, Restorable {
 			clip.setArcHeight(43);
 			clip.setArcWidth(43);
 			recipientProfilePic.setClip(clip);
-			messageList.getStyleClass().clear();
 			messageSearchButton.setVisible(true);
-
-			// Change the background of the message list if the chat is disabled
-			if (currentChat.isDisabled()) messageList.getStyleClass().add("disabled-chat");
 		}
 	}
 
@@ -749,18 +744,17 @@ public final class ChatScene implements EventListener, Restorable {
 	 * Redesigns the UI when the {@link Chat} of the given contact has been marked
 	 * as disabled.
 	 *
-	 * @param recipient       the contact whose chat got disabled
-	 * @param refreshChatList whether to refresh the chatList
+	 * @param event the contact whose chat got disabled
 	 * @since Envoy Client v0.3-beta
 	 */
-	public void disableChat(Contact recipient, boolean refreshChatList) {
-		if (refreshChatList) {
-			chatList.refresh();
+	@Event
+	public void disableChat(ContactDisabled event) {
+		chatList.refresh();
+		final var recipient = event.get();
 
-			// Decrement member count for groups
-			if (recipient instanceof Group)
-				topBarStatusLabel.setText(recipient.getContacts().size() + " member" + (recipient.getContacts().size() != 1 ? "s" : ""));
-		}
+		// Decrement member count for groups
+		if (recipient instanceof Group)
+			topBarStatusLabel.setText(recipient.getContacts().size() + " member" + (recipient.getContacts().size() != 1 ? "s" : ""));
 		if (currentChat != null && currentChat.getRecipient().equals(recipient)) {
 			messageTextArea.setDisable(true);
 			voiceButton.setDisable(true);
@@ -792,11 +786,7 @@ public final class ChatScene implements EventListener, Restorable {
 		remainingChars.setVisible(false);
 		pendingAttachment = null;
 		recipientProfilePic.setImage(null);
-
-		// It is a valid case that cancel can cause a NullPointerException
-		try {
-			recorder.cancel();
-		} catch (final NullPointerException e) {}
+		if (recorder.isRecording()) recorder.cancel();
 	}
 
 	@FXML
diff --git a/client/src/main/java/envoy/client/ui/listcell/AbstractListCell.java b/client/src/main/java/envoy/client/ui/listcell/AbstractListCell.java
index 1e12021..842f0fd 100644
--- a/client/src/main/java/envoy/client/ui/listcell/AbstractListCell.java
+++ b/client/src/main/java/envoy/client/ui/listcell/AbstractListCell.java
@@ -33,6 +33,7 @@ public abstract class AbstractListCell<T, U extends Node> extends ListCell<T> {
 			setGraphic(renderItem(item));
 		} else {
 			setGraphic(null);
+			setCursor(Cursor.DEFAULT);
 		}
 	}
 
diff --git a/client/src/main/java/envoy/client/ui/listcell/ChatListCell.java b/client/src/main/java/envoy/client/ui/listcell/ChatListCell.java
new file mode 100644
index 0000000..ccaa6dd
--- /dev/null
+++ b/client/src/main/java/envoy/client/ui/listcell/ChatListCell.java
@@ -0,0 +1,46 @@
+package envoy.client.ui.listcell;
+
+import javafx.scene.control.*;
+
+import envoy.client.data.*;
+import envoy.client.net.Client;
+import envoy.client.ui.control.ChatControl;
+import envoy.client.util.UserUtil;
+import envoy.data.User;
+
+/**
+ * A list cell containing chats represented as chat controls.
+ *
+ * @author Leon Hofmeister
+ * @since Envoy Client v0.3-beta
+ */
+public class ChatListCell extends AbstractListCell<Chat, ChatControl> {
+
+	private static final Client client = Context.getInstance().getClient();
+
+	/**
+	 * @param listView the list view inside of which the cell will be displayed
+	 * @since Envoy Client v0.3-beta
+	 */
+	public ChatListCell(ListView<? extends Chat> listView) { super(listView); }
+
+	@Override
+	protected ChatControl renderItem(Chat chat) {
+		if (client.isOnline()) {
+			final var	menu		= new ContextMenu();
+			final var	removeMI	= new MenuItem();
+			removeMI.setText(
+					chat.isDisabled() ? "Delete " : chat.getRecipient() instanceof User ? "Block " : "Leave group " + chat.getRecipient().getName());
+			removeMI.setOnAction(
+					chat.isDisabled() ? e -> UserUtil.deleteContact(chat.getRecipient()) : e -> UserUtil.disableContact(chat.getRecipient()));
+			menu.getItems().add(removeMI);
+			setContextMenu(menu);
+		} else setContextMenu(null);
+
+		// TODO: replace with icon in ChatControl
+		final var chatControl = new ChatControl(chat);
+		if (chat.isDisabled()) chatControl.getStyleClass().add("disabled-chat");
+		else chatControl.getStyleClass().remove("disabled-chat");
+		return chatControl;
+	}
+}
diff --git a/client/src/main/java/envoy/client/util/UserUtil.java b/client/src/main/java/envoy/client/util/UserUtil.java
index 404dd23..a15d9cc 100644
--- a/client/src/main/java/envoy/client/util/UserUtil.java
+++ b/client/src/main/java/envoy/client/util/UserUtil.java
@@ -5,7 +5,7 @@ import java.util.logging.*;
 import javafx.scene.control.Alert;
 import javafx.scene.control.Alert.AlertType;
 
-import envoy.client.data.*;
+import envoy.client.data.Context;
 import envoy.client.event.*;
 import envoy.client.helper.*;
 import envoy.client.ui.SceneContext.SceneInfo;
@@ -70,31 +70,24 @@ public final class UserUtil {
 	}
 
 	/**
-	 * Removes the given contact. Should not be confused with the method that is
-	 * called when the server reports that a contact has been deleted while the user
-	 * was offline.
+	 * Removes the given contact.
 	 *
 	 * @param block the contact that should be removed
 	 * @since Envoy Client v0.3-beta
-	 * @see LocalDB#setUserAndMergeContacts(envoy.data.User)
 	 */
-	public static void blockContact(Contact block) {
+	public static void disableContact(Contact block) {
 		if (!context.getClient().isOnline() || block == null) return;
 		else {
 			final var alert = new Alert(AlertType.CONFIRMATION);
 			alert.setContentText("Are you sure you want to " + (block instanceof User ? "block " : "leave group ") + block.getName() + "?");
 			AlertHelper.confirmAction(alert, () -> {
+				final var isUser = block instanceof User;
 				context.getClient()
-					.send(block instanceof User ? new UserOperation((User) block, ElementOperation.REMOVE)
+					.send(isUser ? new UserOperation((User) block, ElementOperation.REMOVE)
 							: new GroupResize(context.getLocalDB().getUser(), (Group) block, ElementOperation.REMOVE));
-				context.getLocalDB().getChat(block.getID()).ifPresent(chat -> chat.setDisabled(true));
-				if (block instanceof User) logger.log(Level.INFO, "A user was blocked.");
-				else {
-					block.getContacts().remove(context.getLocalDB().getUser());
-					logger.log(Level.INFO, "The user left a group.");
-				}
-				final var controller = context.getSceneContext().getController();
-				if (controller instanceof ChatScene) ((ChatScene) controller).disableChat(block, true);
+				if (!isUser) block.getContacts().remove(context.getLocalDB().getUser());
+				EventBus.getInstance().dispatch(new ContactDisabled(block));
+				logger.log(Level.INFO, isUser ? "A user was blocked." : "The user left a group.");
 			});
 		}
 	}
diff --git a/client/src/main/resources/css/base.css b/client/src/main/resources/css/base.css
index bfe4da2..4c46161 100644
--- a/client/src/main/resources/css/base.css
+++ b/client/src/main/resources/css/base.css
@@ -147,7 +147,7 @@
 }
 
 .disabled-chat {
-	-fx-background-color: #F04000;
+	-fx-background-color: #0000FF;
 }
 
 #quick-select-list .scroll-bar:horizontal{
diff --git a/common/src/main/java/envoy/util/SerializationUtils.java b/common/src/main/java/envoy/util/SerializationUtils.java
index 4bc4516..f556657 100644
--- a/common/src/main/java/envoy/util/SerializationUtils.java
+++ b/common/src/main/java/envoy/util/SerializationUtils.java
@@ -105,7 +105,7 @@ public final class SerializationUtils {
 			file.createNewFile();
 		}
 		try (ObjectOutputStream out = new ObjectOutputStream(new FileOutputStream(file))) {
-			for (final var obj : objs)
+			for (var obj : objs)
 				out.writeObject(obj);
 		}
 	}
@@ -119,7 +119,7 @@ public final class SerializationUtils {
 	 * @since Envoy Common v0.2-alpha
 	 */
 	public static byte[] writeToByteArray(Object obj) throws IOException {
-		final var baos = new ByteArrayOutputStream();
+		ByteArrayOutputStream baos = new ByteArrayOutputStream();
 		try (ObjectOutputStream oout = new ObjectOutputStream(baos)) {
 			oout.writeObject(obj);
 		}
@@ -137,10 +137,10 @@ public final class SerializationUtils {
 	 */
 	public static void writeBytesWithLength(Object obj, OutputStream out) throws IOException {
 		// Serialize object to byte array
-		final var objBytes = writeToByteArray(obj);
+		byte[] objBytes = writeToByteArray(obj);
 
 		// Get length of byte array in bytes
-		final var objLen = intToBytes(objBytes.length);
+		byte[] objLen = intToBytes(objBytes.length);
 
 		// Write length and byte array
 		out.write(objLen);
-- 
2.30.2