Labels Milestones

Properly Handle Nested Dispatches #19

Merged

kske merged 3 commits from b/nested-dispatch into develop 1 year ago

Conversation 0 Commits 3 Files Changed 2

kske commented 1 year ago

Owner

Instead of setting a boolean when a dispatch happens, an integer is incremented when the dispatch begins and decremented when it ends, thus keepnig track of nested calls to the dispatch method.

In addition, a minor bug has been fixed that caused errors (for example thrown by a JUnit assertion) to be handled using an exception event instead of being transparently propagated to the caller as intended.

Fixes #18

Instead of setting a boolean when a dispatch happens, an integer is incremented when the dispatch begins and decremented when it ends, thus keepnig track of nested calls to the `dispatch` method. In addition, a minor bug has been fixed that caused errors (for example thrown by a JUnit assertion) to be handled using an exception event instead of being transparently propagated to the caller as intended. Fixes #18

kske added the

core

bug

labels 1 year ago

kske self-assigned this 1 year ago

kske added 3 commits 1 year ago

6eebd3c121

Pass errors caused during system event dispatch to caller ...

When an error is caused during the dispatch of a system event, a warning
has been logged instead instead of rethrowing the error. This has been
fixed.

This enables failing a JUnit test when an exception event handler is
invoked.

74447dea59

Add nested dispatch test ...

The test performs a nested event dispatch then cancels the dispatch. If
Both operations are successful, the test is successful.

Currently, the test fails, but should be successful once the nested
dispatch bug is fixed.

205a183db7

Allow nested dispatches by keeping track of nesting count

kske requested review from delvh 1 year ago

delvh approved these changes 1 year ago

kske merged commit b915a5c490 into develop 1 year ago

kske referenced this issue from a commit 1 year ago

Merge pull request 'Properly Handle Nested Dispatches' (#19) from b/nested-dispatch into develop

kske deleted branch b/nested-dispatch 1 year ago

Reviewers

delvh approved these changes 1 year ago

The pull request has been merged as b915a5c490.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

delvh

Labels

Apply labels

Clear labels

1
1 13
13 2
2 21
21 3
3 34
34 5
5 55
55 8
8 bug
Something isn't working core
Event Bus Core could have
This doesn't hurt duplicate
This issue or pull request already exists enhancement
New feature or request help wanted
Extra attention is needed must have
This is absolutely necessary proc
Event Bus Proc question
Further information is needed should have
This should be implemented wont have
This won't be implemented (for now)

bug
Something is not working bugfix
Fixes a bug discussion
This has to be discussed documentation
Related to documentation feature
Introduces a new feature L
Branches where 300 < X <= 600 lines are added and more than one work day is needed M
Branches where 100 < X <=300 lines are added maintenance
Related to project maintenance S
Branches where X <= 100 lines are added or less than 30 minutes are needed wontfix
Will not be fixed in this state of development XL
Branch where X > 600 lines are added and more than two work days are needed

No Label 1 13 2 21 3 34 5 55 8 bug core could have duplicate enhancement help wanted must have proc question should have wont have bug bugfix discussion documentation feature L M maintenance S wontfix XL

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

kske

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: zdm/event-bus#19

Write Preview

Loading…

Cancel

Save

There is no content yet.