Handler Caching #37

Merged
kske merged 5 commits from f/handler-caching into develop 4 months ago
kske commented 4 months ago
Owner

Closes #20

Closes #20
kske self-assigned this 4 months ago
kske added 2 commits 4 months ago
5468bddb35
Add handler cache
ee9d08b2b8
Test binding cache
kske requested review from delvh 4 months ago
kske added 1 commit 4 months ago
8609c6a90c
Simplify binding cache usage
delvh approved these changes 4 months ago
var it = binding.iterator();
while (it.hasNext()) {
var handler = it.next();
if (handler.getListener() == listener) {
delvh commented 4 months ago
Owner

Maybe add a comment on why == instead of equals.

Maybe add a comment on why `==` instead of `equals`.
kske commented 4 months ago
Poster
Owner

As we implicitly test using equals in registerListener(...), I will change this as well.

As we implicitly test using `equals` in `registerListener(...)`, I will change this as well.
kske marked this conversation as resolved
@Test
void testBindingCache() {
String executionOrder = bus.debugExecutionOrder(SimpleEventSub.class);
System.out.println(executionOrder);
delvh commented 4 months ago
Owner

Why?

Why?
kske marked this conversation as resolved
kske added 1 commit 4 months ago
kske added 1 commit 4 months ago
8fae4f6d76
Remove print statements from test
kske merged commit cc5c07079a into develop 4 months ago
kske deleted branch f/handler-caching 4 months ago

Reviewers

delvh approved these changes 4 months ago
zdm/event-bus/pipeline/head This commit looks good
The pull request has been merged as cc5c07079a.
Sign in to join this conversation.
Loading…
There is no content yet.