Handler Caching #37

Merged
kske merged 5 commits from f/handler-caching into develop 2022-01-18 17:11:38 +01:00

Closes #20

Closes #20
kske self-assigned this 2022-01-18 13:48:21 +01:00
kske added 2 commits 2022-01-18 13:48:22 +01:00
zdm/event-bus/pipeline/head This commit looks good Details
5468bddb35
Add handler cache
The cache has the same structure as the bindings and is updated
accordingly. To ensure the correctness and efficiency of the cache, more
testing has to be conducted.
zdm/event-bus/pipeline/head This commit looks good Details
ee9d08b2b8
Test binding cache
kske requested review from delvh 2022-01-18 13:48:25 +01:00
kske added 1 commit 2022-01-18 15:00:21 +01:00
zdm/event-bus/pipeline/head This commit looks good Details
8609c6a90c
Simplify binding cache usage
delvh approved these changes 2022-01-18 16:08:47 +01:00
@ -405,0 +435,4 @@
var it = binding.iterator();
while (it.hasNext()) {
var handler = it.next();
if (handler.getListener() == listener) {

Maybe add a comment on why == instead of equals.

Maybe add a comment on why `==` instead of `equals`.
Poster
Owner

As we implicitly test using equals in registerListener(...), I will change this as well.

As we implicitly test using `equals` in `registerListener(...)`, I will change this as well.
kske marked this conversation as resolved
@ -67,0 +71,4 @@
@Test
void testBindingCache() {
String executionOrder = bus.debugExecutionOrder(SimpleEventSub.class);
System.out.println(executionOrder);

Why?

Why?
kske marked this conversation as resolved
kske added 1 commit 2022-01-18 17:09:07 +01:00
kske added 1 commit 2022-01-18 17:09:23 +01:00
zdm/event-bus/pipeline/head This commit looks good Details
8fae4f6d76
Remove print statements from test
kske merged commit cc5c07079a into develop 2022-01-18 17:11:38 +01:00
kske deleted branch f/handler-caching 2022-01-18 17:11:38 +01:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: zdm/event-bus#37
There is no content yet.