Improve Scene Switching #109

Merged
kske merged 5 commits from improved-scene-switching into develop 2 years ago
kske commented 2 years ago
Owner

This pull request improves the scene switching mechanism implemented in SceneContext.

Instead of creating a new scene every time a scene change is triggered, the same scene is reused with another root node.

By adjusting the initial size of the scene to that of the stage, the stage is now resized during a scene change, resulting in a superior user experience.

Fixes #89

This pull request improves the scene switching mechanism implemented in `SceneContext`. Instead of creating a new scene every time a scene change is triggered, the same scene is reused with another root node. By adjusting the initial size of the scene to that of the stage, the stage is now resized during a scene change, resulting in a superior user experience. Fixes #89
kske added this to the v0.3-beta milestone 2 years ago
kske added the
bug
client
M
labels 2 years ago
kske self-assigned this 2 years ago
delvh approved these changes 2 years ago
delvh left a comment
Owner

👍 Seems fine

👍 Seems fine
Owner

I like how you didn't even assign @DieGurke as a reviewer...

I like how you didn't even assign @DieGurke as a reviewer...
delvh added the due date 2020-11-22 2 years ago
delvh reviewed 2 years ago
applyCSS();
stage.show();
} catch (final IOException e) {
EnvoyLog.getLogger(SceneContext.class).log(Level.SEVERE,
Owner

Wait, you don't want to log the failed loading?

Wait, you don't want to log the failed loading?
kske marked this conversation as resolved
kske requested review from DieGurke 2 years ago
DieGurke approved these changes 2 years ago
delvh approved these changes 2 years ago
delvh left a comment
Owner

👍

👍
kske merged commit 0ff910ebde into develop 2 years ago
kske deleted branch improved-scene-switching 2 years ago
This repo is archived. You cannot comment on pull requests.
Loading…
There is no content yet.