Send Pending Messages After Successful Handshake #111

Merged
kske merged 1 commits from b/slow-handshake into develop 1 year ago
kske commented 1 year ago
Owner

Instead of caching pending messages during the handshake and relaying
them afterwards, they are now sent after the handshake has been
completed.

This is possible because the relevant processors (messages and status
changes) are now event handlers which are registered at the event bus,
which means that they can immediately react to pending messages even if
Client#initReceiver has not been fully executed yet.

Because Client#initReceiver exists for that very reason, it is no
longer necessary anymore. ID generator initialization, which was its other part,
is now directly handled in Startup#performHandshake, which is a far more
sensible placement.

Fixes #106

Instead of caching pending messages during the handshake and relaying them afterwards, they are now sent after the handshake has been completed. This is possible because the relevant processors (messages and status changes) are now event handlers which are registered at the event bus, which means that they can immediately react to pending messages even if `Client#initReceiver` has not been fully executed yet. Because `Client#initReceiver` exists for that very reason, it is no longer necessary anymore. ID generator initialization, which was its other part, is now directly handled in `Startup#performHandshake`, which is a far more sensible placement. Fixes #106
kske added this to the v0.3-beta milestone 1 year ago
kske added the
bug
server
client
M
labels 1 year ago
kske self-assigned this 1 year ago
kske requested review from delvh 1 year ago
kske requested review from DieGurke 1 year ago
DieGurke approved these changes 1 year ago
Owner

👍

:+1:
kske merged commit dcf1b0c58d into develop 1 year ago
kske deleted branch b/slow-handshake 1 year ago
This repo is archived. You cannot comment on pull requests.
Loading…
There is no content yet.