Labels Milestones

Send Pending Messages After Successful Handshake #111

Merged

kske merged 1 commits from b/slow-handshake into develop 1 year ago

Conversation 1 Commits 1 Files Changed 3

kske commented 1 year ago

Owner

Instead of caching pending messages during the handshake and relaying
them afterwards, they are now sent after the handshake has been
completed.

This is possible because the relevant processors (messages and status
changes) are now event handlers which are registered at the event bus,
which means that they can immediately react to pending messages even if
Client#initReceiver has not been fully executed yet.

Because Client#initReceiver exists for that very reason, it is no
longer necessary anymore. ID generator initialization, which was its other part,
is now directly handled in Startup#performHandshake, which is a far more
sensible placement.

Fixes #106

Instead of caching pending messages during the handshake and relaying them afterwards, they are now sent after the handshake has been completed. This is possible because the relevant processors (messages and status changes) are now event handlers which are registered at the event bus, which means that they can immediately react to pending messages even if `Client#initReceiver` has not been fully executed yet. Because `Client#initReceiver` exists for that very reason, it is no longer necessary anymore. ID generator initialization, which was its other part, is now directly handled in `Startup#performHandshake`, which is a far more sensible placement. Fixes #106

kske added this to the v0.3-beta milestone 1 year ago

kske added the

bug

server

client

M

labels 1 year ago

kske self-assigned this 1 year ago

kske requested review from delvh 1 year ago

kske requested review from DieGurke 1 year ago

DieGurke approved these changes 1 year ago

delvh commented 1 year ago

Owner

👍

:+1:

kske referenced this issue from a commit 1 year ago

Send Pending Messages After Successful Handshake (#111) Instead of caching pending messages during the handshake and relaying them afterwards, they are now sent after the handshake has been completed. This is possible because the relevant processors (messages and status changes) are now event handlers which are registered at the event bus, which means that they can immediately react to pending messages even if Client#initReceiver has not been fully executed yet. Because Client#initReceiver exists for that very reason, it is no longer necessary anymore. ID generator initialization, which was its other part, is now directly handled in Startup#performHandshake, which is a far more sensible placement. Fixes #106 Reviewed-on: https://git.kske.dev/zdm/envoy/pulls/111 Reviewed-by: DieGurke <maxi@kske.dev>

kske merged commit dcf1b0c58d into develop 1 year ago

kske deleted branch b/slow-handshake 1 year ago

This repo is archived. You cannot comment on pull requests.

Reviewers

Request review

No reviewers

delvh

DieGurke

Labels

Apply labels

Clear labels

client
Envoy Client server
Envoy Server user made
This issue has been created through Envoy

bug
Something is not working bugfix
Fixes a bug documentation
Related to documentation feature
Introduces a new feature L
Branches where 300 < X <= 600 lines are added and more than one work day is needed M
Branches where 100 < X <=300 lines are added maintenance
Related to project maintenance S
Branches where X <= 100 lines are added or less than 30 minutes are needed XL
Branch where X > 600 lines are added and more than two work days are needed

No Label client server user made bug bugfix documentation feature L M maintenance S XL

Milestone

Set milestone

Clear milestone

No items

No Milestone

v0.3-beta

Assignees

Assign users

Clear assignees

No Assignees

kske

3 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.