Add Ability to Logout #50

Merged
kske merged 7 commits from f/logout into develop 2 years ago
delvh commented 2 years ago
Owner

Additionally added keyboard shortcuts and system commands for logout, exit and switching to the settings scene

Additionally added keyboard shortcuts and system commands for logout, exit and switching to the settings scene
delvh added this to the v0.2-beta milestone 2 years ago
delvh added the
client
L
labels 2 years ago
delvh self-assigned this 2 years ago
delvh requested review from DieGurke 2 years ago
delvh requested review from kske 2 years ago
kske requested changes 2 years ago
kske left a comment
Owner

Looks good to me, please fix the cosmetics though 😆

Looks good to me, please fix the cosmetics though 😆
private CacheMap cacheMap = new CacheMap();
private String authToken;
// auto save Timer
kske commented 2 years ago
Owner

This should be // Auto save time.

This should be `// Auto save time`.
delvh commented 2 years ago
Poster
Owner

you mean // Auto save timer?

you mean `// Auto save timer`?
new Timer("LocalDB Autosave", true).schedule(new TimerTask() {
if (autoSaveRestart) {
// A logout happened so the timer should be restarted
kske commented 2 years ago
Owner

Maybe move the comment above the if statement.

Maybe move the comment above the `if` statement.
delvh marked this conversation as resolved
* @since Envoy Client v0.2-beta
*/
@Event(eventType = Logout.class, priority = 100)
public void onLogout() {
kske commented 2 years ago
Owner

Why is this public?

Why is this public?
delvh marked this conversation as resolved
authToken = null;
chats.clear();
lastSync = Instant.EPOCH;
cacheMap.getMap().forEach((key, cache) -> cache.clear());
kske commented 2 years ago
Owner

Please remove the comment and add a clearing method to CacheMap.

Please remove the comment and add a clearing method to `CacheMap`.
delvh marked this conversation as resolved
/**
* Indicates that a logout has been requested.
*
* @author leon
kske commented 2 years ago
Owner

Fix your @author tag.

Fix your `@author` tag.
delvh marked this conversation as resolved
* @author Leon Hofmeister
* @since Envoy Client v0.2-beta
*/
public class AlertHelper {
kske commented 2 years ago
Owner

Make this final.

Make this `final`.
delvh marked this conversation as resolved
import dev.kske.eventbus.EventBus;
/**
* Contains methods that have a direct impact on the user.
kske commented 2 years ago
Owner

What on earth does that even mean?

What on earth does that even mean?
delvh commented 2 years ago
Poster
Owner

Changed it now.
If you don't like it, suggest a better alternative.
I cannot think of one.

Changed it now. If you don't like it, suggest a better alternative. I cannot think of one.
* @author Leon Hofmeister
* @since Envoy Client v0.2-beta
*/
public class ShutdownHelper {
kske commented 2 years ago
Owner

Make this final.

Make this `final`.
delvh marked this conversation as resolved
delvh requested review from kske 2 years ago
kske approved these changes 2 years ago
kske merged commit c7ee545ee2 into develop 2 years ago
kske deleted branch f/logout 2 years ago
This repo is archived. You cannot comment on pull requests.
Loading…
There is no content yet.