Remove USE_PARAMETER #35

Merged
kske merged 4 commits from f/remove-use-parameter into develop 7 months ago
kske commented 7 months ago
Owner

Use void.class instead of USE_PARAMETER.class which was introduced for reasons no longer present.

Additionally, update the accessibility of reflective event handler methods only if that's actually necessary. That way, public handlers can be can be invoked reflectively without opening the containing module to Event Bus.

Use `void.class` instead of `USE_PARAMETER.class` which was introduced for reasons no longer present. Additionally, update the accessibility of reflective event handler methods only if that's actually necessary. That way, public handlers can be can be invoked reflectively without opening the containing module to Event Bus.
kske self-assigned this 7 months ago
kske added 3 commits 7 months ago
36ed55fd71
Use void.class to determine how the event handler type is defined
3aef7d5bcb
Only update handler accessibility if necessary
8615a0e021
Fix Event Bus Proc module name
kske requested review from delvh 7 months ago
kske changed title from f/remove-use-parameter to Remove USE_PARAMETER 7 months ago
kske added 1 commit 7 months ago
6ee4e11161
Fix inconsistent test
delvh approved these changes 7 months ago
this.listener = listener;
this.method = method;
useParameter = annotation.value() == USE_PARAMETER.class;
useParameter = annotation.value() == void.class;
delvh commented 7 months ago
Owner

|| annotation.value == Void.class

`|| annotation.value == Void.class`
kske commented 7 months ago
Poster
Owner

That wouldn't be the default type though. Yes, using Void as an event type doesn't make much sense, but it is possible, which isn't the case for void.

That wouldn't be the default type though. Yes, using `Void` as an event type doesn't make much sense, but it is possible, which isn't the case for `void`.
delvh marked this conversation as resolved
kske merged commit a8d858e8c7 into develop 7 months ago
kske deleted branch f/remove-use-parameter 7 months ago

Reviewers

delvh approved these changes 7 months ago
zdm/event-bus/pipeline/head This commit looks good
The pull request has been merged as a8d858e8c7.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zdm/event-bus#35
Loading…
There is no content yet.